Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.2.0 release post title #1516

Merged
merged 1 commit into from Sep 12, 2013

Conversation

Projects
None yet
5 participants
@doktorbro
Copy link
Member

commented Sep 7, 2013

According to previous titles (1.1.0, 1.1.2) the expected version format is full: 1.2.0

@kelvinst

This comment has been minimized.

Copy link

commented Sep 7, 2013

Nice 😃 👍

@doktorbro

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2013

Checkout the different Google search results:

@parkr

This comment has been minimized.

Copy link
Member

commented Sep 10, 2013

Am I the only one for whom this works?

screen shot 2013-09-10 at 12 00 51 pm

@doktorbro

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2013

No, I get this result too. The first item is the right one, the following items are from movie area. Google knows about us. Maybe a non nerd user get the movie results first.

The point is: the version’s name is a string. If you abbreviate it in the post’s title only, but use the full name everywhere else, this can cause a collision and confuse searching people. With full version names you are on the sure side.

Even the post view is confusing:
jekyll-1-2-0-confusing

@mattr-

This comment has been minimized.

Copy link
Member

commented Sep 10, 2013

@parkr I don't have a problem with this. Any reason why we shouldn't merge it?

@parkr

This comment has been minimized.

Copy link
Member

commented Sep 12, 2013

I prefer the shorter title when the patch version isn't necessary but if it really bothers others we can merge it.

parkr added a commit that referenced this pull request Sep 12, 2013

Merge pull request #1516 from penibelst/fix-post-title
Fix 1.2.0 release post title

@parkr parkr merged commit 3fde4f7 into jekyll:master Sep 12, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Sep 12, 2013

@doktorbro doktorbro deleted the doktorbro:fix-post-title branch Sep 12, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.