Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.2.0 release post title #1516

Merged
merged 1 commit into from Sep 12, 2013
Merged

Fix 1.2.0 release post title #1516

merged 1 commit into from Sep 12, 2013

Conversation

doktorbro
Copy link
Member

According to previous titles (1.1.0, 1.1.2) the expected version format is full: 1.2.0

@kelvinst
Copy link

kelvinst commented Sep 7, 2013

Nice 😃 👍

@doktorbro
Copy link
Member Author

Checkout the different Google search results:

@parkr
Copy link
Member

parkr commented Sep 10, 2013

Am I the only one for whom this works?

screen shot 2013-09-10 at 12 00 51 pm

@doktorbro
Copy link
Member Author

No, I get this result too. The first item is the right one, the following items are from movie area. Google knows about us. Maybe a non nerd user get the movie results first.

The point is: the version’s name is a string. If you abbreviate it in the post’s title only, but use the full name everywhere else, this can cause a collision and confuse searching people. With full version names you are on the sure side.

Even the post view is confusing:
jekyll-1-2-0-confusing

@mattr-
Copy link
Member

mattr- commented Sep 10, 2013

@parkr I don't have a problem with this. Any reason why we shouldn't merge it?

@parkr
Copy link
Member

parkr commented Sep 12, 2013

I prefer the shorter title when the patch version isn't necessary but if it really bothers others we can merge it.

parkr added a commit that referenced this pull request Sep 12, 2013
@parkr parkr merged commit 3fde4f7 into jekyll:master Sep 12, 2013
parkr added a commit that referenced this pull request Sep 12, 2013
@doktorbro doktorbro deleted the fix-post-title branch September 12, 2013 20:40
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants