New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print better messages for detached server. Mute output on detach. #1518

Merged
merged 2 commits into from Sep 15, 2013

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Sep 8, 2013

No description provided.

@parkr

This comment has been minimized.

Member

parkr commented Sep 9, 2013

@mattr- @benbalter Thoughts?

@benbalter

This comment has been minimized.

Contributor

benbalter commented Sep 9, 2013

Can you think of an example in which I'd want to run the same jekyll site detached twice at the same time, even if on different ports? Would 80% of the users want to do that?

What if Jekyll wrote a .jekyll.pid file (or similar) to the site directory, and we told the user to fire jekyll stop to stop? Run 'kill -9 #{pid}' to stop the server. is just so ugly. I'm not going to remember that after hacking for an hour. Where was that in my backscroll again? was it -8? what was my PID? And I don't want to have to copy/paste. If instead, I just had to remember anything, and just fire jekyll stop, I (me, literally) would use this feature all the time.

@parkr

This comment has been minimized.

Member

parkr commented Sep 9, 2013

I thought about that actually! My only concern is write privileges.

@parkr

This comment has been minimized.

Member

parkr commented Sep 10, 2013

I think I'll add the kill command in there but I'd first say Run 'jekyll stop' or 'kill -9 #{pid}' to stop the server.

@parkr parkr referenced this pull request Sep 10, 2013

Closed

Mute WEBrick #1403

@parkr

This comment has been minimized.

Member

parkr commented Sep 12, 2013

I often run multiple versions of Jekyll so we'd have to allow --source for jekyll stop.

@parkr

This comment has been minimized.

Member

parkr commented Sep 12, 2013

Let's push jekyll stop off to v1.3 as it would require a MINOR version bump.

@mattr-

This comment has been minimized.

Member

mattr- commented Sep 12, 2013

👍 :shipit:

@parkr

This comment has been minimized.

Member

parkr commented Sep 12, 2013

Hm, I can't get -w to work with this.

@parkr

This comment has been minimized.

Member

parkr commented Sep 12, 2013

I guess the suggestion would be to run jekyll serve -B then jekyll build -w? :/

@maul-esel maul-esel referenced this pull request Sep 13, 2013

Closed

refactor commands #1535

parkr added a commit that referenced this pull request Sep 15, 2013

Merge pull request #1518 from mojombo/fix-serve-detatch
Print better messages for detached server. Mute output on detach.

@parkr parkr merged commit 3ddc33c into master Sep 15, 2013

1 check passed

default The Travis CI build passed
Details

@parkr parkr deleted the fix-serve-detatch branch Sep 15, 2013

parkr added a commit that referenced this pull request Sep 15, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.