Print better messages for detached server. Mute output on detach. #1518

Merged
merged 2 commits into from Sep 15, 2013

Projects

None yet

3 participants

@parkr
Member
parkr commented Sep 8, 2013

No description provided.

@parkr
Member
parkr commented Sep 9, 2013

@mattr- @benbalter Thoughts?

@benbalter
Contributor

Can you think of an example in which I'd want to run the same jekyll site detached twice at the same time, even if on different ports? Would 80% of the users want to do that?

What if Jekyll wrote a .jekyll.pid file (or similar) to the site directory, and we told the user to fire jekyll stop to stop? Run 'kill -9 #{pid}' to stop the server. is just so ugly. I'm not going to remember that after hacking for an hour. Where was that in my backscroll again? was it -8? what was my PID? And I don't want to have to copy/paste. If instead, I just had to remember anything, and just fire jekyll stop, I (me, literally) would use this feature all the time.

@parkr
Member
parkr commented Sep 9, 2013

I thought about that actually! My only concern is write privileges.

@parkr
Member
parkr commented Sep 10, 2013

I think I'll add the kill command in there but I'd first say Run 'jekyll stop' or 'kill -9 #{pid}' to stop the server.

@parkr parkr referenced this pull request Sep 10, 2013
Closed

Mute WEBrick #1403

@parkr
Member
parkr commented Sep 12, 2013

I often run multiple versions of Jekyll so we'd have to allow --source for jekyll stop.

@parkr
Member
parkr commented Sep 12, 2013

Let's push jekyll stop off to v1.3 as it would require a MINOR version bump.

@mattr-
Member
mattr- commented Sep 12, 2013

👍 :shipit:

@parkr
Member
parkr commented Sep 12, 2013

Hm, I can't get -w to work with this.

@parkr
Member
parkr commented Sep 12, 2013

I guess the suggestion would be to run jekyll serve -B then jekyll build -w? :/

@maul-esel maul-esel referenced this pull request Sep 13, 2013
Closed

refactor commands #1535

@parkr parkr merged commit 3ddc33c into master Sep 15, 2013

1 check passed

default The Travis CI build passed
Details
@parkr parkr deleted the fix-serve-detatch branch Sep 15, 2013
@parkr parkr added a commit that referenced this pull request Sep 15, 2013
@parkr parkr Update history to reflect merge of #1518 a1e16b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment