Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a patch for the issue #1519: Liquid doesn't render my partial #1525

Merged
merged 1 commit into from Sep 12, 2013

Conversation

@zerobase
Copy link

@zerobase zerobase commented Sep 10, 2013

…· mojombo/jekyll](#1519)
@parkr
Copy link
Member

@parkr parkr commented Sep 10, 2013

Is there documentation on that method in the Liquid API you could point me to?

@zerobase
Copy link
Author

@zerobase zerobase commented Sep 10, 2013

I couldn't find any document on Tag#blank? but you can find how it works in this test code: liquid/test/liquid/tags/include_tag_test.rb.

If you remove the CustomInclude#blank? (line 207-209) you'll get a failure:

test_custom_include_tag_within_if_statement(IncludeTagTest) [/Users/ishibashi/dev/liquid/test/liquid/tags/include_tag_test.rb:187]:
<"custom_foo_if_true"> expected but was
<"">.
@parkr
Copy link
Member

@parkr parkr commented Sep 11, 2013

I'm 👍 on this. @mattr-?

@mattr-
Copy link
Member

@mattr- mattr- commented Sep 12, 2013

:+1 :shipit:

parkr added a commit that referenced this pull request Sep 12, 2013
Force rendering of Include tag. Fixes #1519.
@parkr parkr merged commit 5c23ae1 into jekyll:master Sep 12, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
parkr added a commit that referenced this pull request Sep 12, 2013
@zerobase zerobase deleted the zerobase:issue1519 branch Sep 12, 2013
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants