a patch for the issue #1519: Liquid doesn't render my partial #1525

Merged
merged 1 commit into from Sep 12, 2013

Projects

None yet

3 participants

@parkr
Member
parkr commented Sep 10, 2013

Is there documentation on that method in the Liquid API you could point me to?

@zerobase

I couldn't find any document on Tag#blank? but you can find how it works in this test code: liquid/test/liquid/tags/include_tag_test.rb.

If you remove the CustomInclude#blank? (line 207-209) you'll get a failure:

test_custom_include_tag_within_if_statement(IncludeTagTest) [/Users/ishibashi/dev/liquid/test/liquid/tags/include_tag_test.rb:187]:
<"custom_foo_if_true"> expected but was
<"">.
@parkr
Member
parkr commented Sep 11, 2013

I'm 👍 on this. @mattr-?

@mattr-
Member
mattr- commented Sep 12, 2013

:+1 :shipit:

@parkr parkr merged commit 5c23ae1 into jekyll:master Sep 12, 2013

1 check passed

default The Travis CI build passed
Details
@parkr parkr added a commit that referenced this pull request Sep 12, 2013
@parkr parkr Update history to reflect merge of #1525 e653059
@zerobase zerobase deleted the unknown repository branch Sep 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment