New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a patch for the issue #1519: Liquid doesn't render my partial #1525

Merged
merged 1 commit into from Sep 12, 2013

Conversation

Projects
None yet
4 participants
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 10, 2013

Member

Is there documentation on that method in the Liquid API you could point me to?

Member

parkr commented Sep 10, 2013

Is there documentation on that method in the Liquid API you could point me to?

@zerobase

This comment has been minimized.

Show comment
Hide comment
@zerobase

zerobase Sep 10, 2013

I couldn't find any document on Tag#blank? but you can find how it works in this test code: liquid/test/liquid/tags/include_tag_test.rb.

If you remove the CustomInclude#blank? (line 207-209) you'll get a failure:

test_custom_include_tag_within_if_statement(IncludeTagTest) [/Users/ishibashi/dev/liquid/test/liquid/tags/include_tag_test.rb:187]:
<"custom_foo_if_true"> expected but was
<"">.

zerobase commented Sep 10, 2013

I couldn't find any document on Tag#blank? but you can find how it works in this test code: liquid/test/liquid/tags/include_tag_test.rb.

If you remove the CustomInclude#blank? (line 207-209) you'll get a failure:

test_custom_include_tag_within_if_statement(IncludeTagTest) [/Users/ishibashi/dev/liquid/test/liquid/tags/include_tag_test.rb:187]:
<"custom_foo_if_true"> expected but was
<"">.
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 11, 2013

Member

I'm 👍 on this. @mattr-?

Member

parkr commented Sep 11, 2013

I'm 👍 on this. @mattr-?

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Sep 12, 2013

Member

:+1 :shipit:

Member

mattr- commented Sep 12, 2013

:+1 :shipit:

parkr added a commit that referenced this pull request Sep 12, 2013

Merge pull request #1525 from zerobase/issue1519
Force rendering of Include tag. Fixes #1519.

@parkr parkr merged commit 5c23ae1 into jekyll:master Sep 12, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Sep 12, 2013

@zerobase zerobase deleted the zerobase:issue1519 branch Sep 12, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.