Upgrade to Liquid >= 2.5.2, < 2.6 #1536

Merged
merged 1 commit into from Sep 12, 2013

Projects

None yet

3 participants

@benbalter
Contributor

Isn't 2.5.2 within ~>2.5.1?

@parkr
Member
parkr commented Sep 12, 2013

Yes! But 2.5.2 fixes some things so use of 2.5.1 is discouraged.

@benbalter
Contributor

Just read the tag diff. gotcha 👍

@parkr
Member
parkr commented Sep 12, 2013

❤️

@benbalter benbalter referenced this pull request in github/pages-gem Sep 12, 2013
@benbalter benbalter bump liquid and redcarpet f09dd3e
@parkr
Member
parkr commented Sep 12, 2013

Closing :( Check out da commit in github/pages-gem referenced above.

@parkr parkr closed this Sep 12, 2013
@parkr parkr deleted the liquid-2.5.2 branch Sep 12, 2013
@benbalter
Contributor

I believe it may be fixed on HEAD?

@parkr parkr restored the liquid-2.5.2 branch Sep 12, 2013
@parkr parkr reopened this Sep 12, 2013
@parkr
Member
parkr commented Sep 12, 2013

@benbalter: ok, why don't I merge this and release 1.2.1 so you can push up to GH Pages?

@benbalter
Contributor

@parkr haven't bumped to 1.2.0 yet, but rolled back liquid, so we should be good.

@parkr parkr merged commit 34a888e into master Sep 12, 2013

1 check was pending

default The Travis CI build is in progress
Details
@parkr parkr deleted the liquid-2.5.2 branch Sep 12, 2013
@parkr parkr added a commit that referenced this pull request Sep 12, 2013
@parkr parkr Update history to reflect merge of #1536 214c851
@anatol
anatol commented on db397da Jan 1, 2014

btw liquid 2.6.0 is out

Member
parkr replied Jan 1, 2014

Yeah we haven't been able to check up on that version yet. Some things were broken in v2.5.3 that are in 2.6.x that broke things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment