New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Liquid >= 2.5.2, < 2.6 #1536

Merged
merged 1 commit into from Sep 12, 2013

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Sep 12, 2013

@benbalter

This comment has been minimized.

Contributor

benbalter commented Sep 12, 2013

Isn't 2.5.2 within ~>2.5.1?

@parkr

This comment has been minimized.

Member

parkr commented Sep 12, 2013

Yes! But 2.5.2 fixes some things so use of 2.5.1 is discouraged.

@benbalter

This comment has been minimized.

Contributor

benbalter commented Sep 12, 2013

Just read the tag diff. gotcha 👍

@parkr

This comment has been minimized.

Member

parkr commented Sep 12, 2013

❤️

benbalter referenced this pull request in github/pages-gem Sep 12, 2013

@parkr

This comment has been minimized.

Member

parkr commented Sep 12, 2013

Closing :( Check out da commit in github/pages-gem referenced above.

@parkr parkr closed this Sep 12, 2013

@parkr parkr deleted the liquid-2.5.2 branch Sep 12, 2013

@benbalter

This comment has been minimized.

Contributor

benbalter commented Sep 12, 2013

I believe it may be fixed on HEAD?

@parkr parkr restored the liquid-2.5.2 branch Sep 12, 2013

@parkr parkr reopened this Sep 12, 2013

@parkr

This comment has been minimized.

Member

parkr commented Sep 12, 2013

@benbalter: ok, why don't I merge this and release 1.2.1 so you can push up to GH Pages?

@benbalter

This comment has been minimized.

Contributor

benbalter commented Sep 12, 2013

@parkr haven't bumped to 1.2.0 yet, but rolled back liquid, so we should be good.

parkr added a commit that referenced this pull request Sep 12, 2013

Merge pull request #1536 from mojombo/liquid-2.5.2
Upgrade to Liquid >= 2.5.2, < 2.6

@parkr parkr merged commit 34a888e into master Sep 12, 2013

1 check was pending

default The Travis CI build is in progress
Details

@parkr parkr deleted the liquid-2.5.2 branch Sep 12, 2013

parkr added a commit that referenced this pull request Sep 12, 2013

@anatol

This comment has been minimized.

anatol commented on db397da Jan 1, 2014

btw liquid 2.6.0 is out

This comment has been minimized.

Member

parkr replied Jan 1, 2014

Yeah we haven't been able to check up on that version yet. Some things were broken in v2.5.3 that are in 2.6.x that broke things.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.