New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING docs for better PRs #1537

Merged
merged 1 commit into from Sep 14, 2013

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Sep 12, 2013

  • Focus on site over wiki.
  • Ask for smaller pull requests.
  • Ask for a description with motivations, what was done and any tasks.
  • Use bundle exec rake
  • Remove superfluous newline toward end of file.

Was talking with @maul-esel and thought it would be only fair to ask these things of our awesome contributors if we said it up-front. We want to make sure that contributions are manageable for our maintainers and still easy for our contributors. 馃槃 馃帀

@parkr

This comment has been minimized.

Member

parkr commented Sep 12, 2013

@mattr-, what do you think of these?

@mattr-

This comment has been minimized.

Member

mattr- commented Sep 14, 2013

馃

mattr- added a commit that referenced this pull request Sep 14, 2013

Merge pull request #1537 from mojombo/better-pr
Update CONTRIBUTING docs for better PRs

@mattr- mattr- merged commit 46da096 into master Sep 14, 2013

1 check passed

default The Travis CI build passed
Details

@mattr- mattr- deleted the better-pr branch Sep 14, 2013

mattr- added a commit that referenced this pull request Sep 14, 2013

@parkr

This comment has been minimized.

Member

parkr commented Sep 15, 2013

We should be sure to update the contributing page on the docs.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.