New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for special handling of kramdown's coderay options #1543

Merged
merged 3 commits into from Oct 17, 2013

Conversation

Projects
None yet
3 participants
@maul-esel
Contributor

maul-esel commented Sep 13, 2013

This PR adds tests for jekyll's special handling of kramdown's coderay options, the reasons being

  1. a general effort to increase test coverage
  2. it appeared broken to me¹

¹ which it actually isn't, but as I had worked the tests out by the time I noticed that, I thought it wouldn't hurt.

@mattr-

This comment has been minimized.

Member

mattr- commented Sep 14, 2013

Cool. Thanks! I think we're getting ready to release 1.2.1 soon, so I'll wait until we've got that out to merge it.

mattr- added a commit that referenced this pull request Oct 17, 2013

Merge pull request #1543 from maul-esel/fix-coderay
Add tests for special handling of kramdown's coderay options

@mattr- mattr- merged commit 0e78459 into jekyll:master Oct 17, 2013

1 check passed

default The Travis CI build passed
Details
@mattr-

This comment has been minimized.

Member

mattr- commented Oct 17, 2013

1.2.1 is long out by now, so 🚢 all the things!

mattr- added a commit that referenced this pull request Oct 17, 2013

@maul-esel maul-esel deleted the maul-esel:fix-coderay branch Oct 17, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.