New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output path in case of liquid error in include file #1596

Merged
merged 2 commits into from Oct 3, 2013

Conversation

Projects
None yet
6 participants
@maul-esel
Contributor

maul-esel commented Oct 1, 2013

As described in #1591, a liquid error in an included file causes jekyll to show an error message for the file where it is included in, not the bad file itself. This PR fixes this.

@parkr

This comment has been minimized.

Member

parkr commented Oct 2, 2013

I dig it. @mattr-?

@@ -86,7 +95,11 @@ def render(context)
context.stack do
context['include'] = parse_params(context) if @params
partial.render(context)
begin
partial.render!(context)

This comment has been minimized.

@kelvinst

kelvinst Oct 2, 2013

NIIICE CATCH! 👍

@kelvinst

This comment has been minimized.

kelvinst commented Oct 2, 2013

Lovely...

attr_accessor :path
def initialize(msg, path)
super msg

This comment has been minimized.

@mattr-

mattr- Oct 3, 2013

Member

could you add parenthesis around msg please?

This comment has been minimized.

@mattr-

mattr- Oct 3, 2013

Member

Whoops, sorry. Got a little merge happy. I'll take care of this. 😃

mattr- added a commit that referenced this pull request Oct 3, 2013

Merge pull request #1596 from maul-esel/error-file
Output path in case of liquid error in include file

@mattr- mattr- merged commit 6abe01f into jekyll:master Oct 3, 2013

1 check failed

default The Travis CI build failed
Details

mattr- added a commit that referenced this pull request Oct 3, 2013

@maul-esel maul-esel deleted the maul-esel:error-file branch Oct 3, 2013

@maul-esel maul-esel referenced this pull request Oct 3, 2013

Merged

Fix error file reporting #1601

@benbalter

This comment has been minimized.

Contributor

benbalter commented Nov 2, 2013

Is this relative to root or absolute path? /cc #1514

@parkr

This comment has been minimized.

Member

parkr commented Nov 2, 2013

@benbalter Either _includes/RELATIVE or Page#path, which should be relative to site route.

@benbalter

This comment has been minimized.

Contributor

benbalter commented Nov 2, 2013

🤘

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.