New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error file reporting #1601

Merged
merged 2 commits into from Oct 4, 2013

Conversation

Projects
None yet
4 participants
@maul-esel
Contributor

maul-esel commented Oct 3, 2013

This PR fixes 2 quirks in jekyll's liquid error reporting, specifically which file the error occured on:

  • Firstly, it extends #1596 to work for parse-time errors (such as unknown tags), while it previously only worked for render-time errors.
  • Secondly, the original report #1591 related to layouts and was thus not fixed by #1596. This PR now also fixes the error reporting for liquid errors in layouts.

Sorry for not testing this before opening #1596, but I had no ruby install available. It's tested this time, for both cases.

//cc @IQAndreas, @mattr-

maul-esel added some commits Oct 3, 2013

Move catching of liquid errors in include tags
The previous code only caught render-time errors. This change
makes it catch parse-time errors as well, such as unknown tags.
output correct path in case of liquid error in layout
As with includes, an error in a layout was reported on the
page that used the layout. Fix this by passing on the path
of the layout that is rendered.
@parkr

This comment has been minimized.

Member

parkr commented Oct 3, 2013

Great catch! Thanks!

@mattr-

This comment has been minimized.

Member

mattr- commented Oct 4, 2013

Awesome. Thanks! ❤️

mattr- added a commit that referenced this pull request Oct 4, 2013

@mattr- mattr- merged commit 2bb2921 into jekyll:master Oct 4, 2013

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Oct 4, 2013

@maul-esel maul-esel deleted the maul-esel:fix-error-file branch Oct 4, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.