New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kramdown dependency to ~> 1.2 #1610

Merged
merged 1 commit into from Oct 4, 2013

Conversation

Projects
None yet
4 participants
@sferik
Contributor

sferik commented Oct 4, 2013

No description provided.

@parkr

This comment has been minimized.

Member

parkr commented Oct 4, 2013

Same comment as with rr - I'd prefer to see 1.2.0 unless there's a good reason not to limit to PATCH level updates.

@parkr

This comment has been minimized.

Member

parkr commented Oct 4, 2013

Per this tweet and my faith that these open-source projects will follow SemVer, I'm cool to accept as-is. @mattr-?

@sferik

This comment has been minimized.

Contributor

sferik commented Oct 4, 2013

If kramdown is following SemVer, ~> 1.2 should be safe. If kramdown is not following SemVer, then all bets are off. There’s nothing to say they won’t break compatibility in a patch release.

IMHO, if a dependency doesn’t follow SemVer, it is undependable and should be replaced by a library that does.

If you’re concerned that kramdown will violate SemVer, you may want to encourage the maintainer (/cc @gettalong) to add a "Versioning" statement to their README, similar to what I’ve done here.

parkr added a commit that referenced this pull request Oct 4, 2013

@parkr parkr merged commit 68306c6 into jekyll:master Oct 4, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Oct 4, 2013

@gettalong

This comment has been minimized.

gettalong commented Oct 4, 2013

I'm not following SemVer per se (I haven't read the website) but just following the established guidelines for versioning a library with major, minor and patch parts in the version number.

@parkr

This comment has been minimized.

Member

parkr commented Oct 4, 2013

Good to know. Thanks, @gettalong. Would you mind adding a "Versioning" statement, as @sferik mentioned?

@gettalong

This comment has been minimized.

gettalong commented Oct 26, 2013

@parkr WIll do.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.