New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup to #1254 Instructions for mimicking GFM #1614

Merged
merged 2 commits into from Oct 11, 2013

Conversation

Projects
None yet
6 participants
@robkorv
Contributor

robkorv commented Oct 5, 2013

See #1254 for discussion

@maul-esel

View changes

docs/github-pages.md Outdated
{% highlight yaml %}
safe: true
lsi: false

This comment has been minimized.

@maul-esel

maul-esel Oct 5, 2013

Contributor

I'd still argue that the two lines above don't belong here. Otherwise, LGTM.

This comment has been minimized.

@kelvinst

kelvinst Oct 7, 2013

I agree with maul-esel

Update github-pages.md
removed settings that don't influence the rendering
@mattr-

This comment has been minimized.

Member

mattr- commented Oct 11, 2013

Looooooove it! 💓

mattr- added a commit that referenced this pull request Oct 11, 2013

Merge pull request #1614 from robkorv/gfm-additions
Followup to #1254 Instructions for mimicking GFM

@mattr- mattr- merged commit 8f932db into jekyll:gh-pages Oct 11, 2013

mattr- added a commit that referenced this pull request Oct 11, 2013

@troyswanson

This comment has been minimized.

Member

troyswanson commented Oct 11, 2013

(that's a high five)

@kelvinst

This comment has been minimized.

kelvinst commented Oct 11, 2013

(just corresponding @troyswanson, cause that are not more embarrassing than a uncorresponded high five)

@troyswanson

This comment has been minimized.

Member

troyswanson commented Oct 11, 2013

I really appreciate that. Was worried I was going to be left hanging.

@kelvinst

This comment has been minimized.

kelvinst commented Oct 11, 2013

You're welcome 👍

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.