New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downcase lexers before passing to Pygments #1615

Merged
merged 3 commits into from Oct 11, 2013

Conversation

Projects
None yet
4 participants
@benbalter
Contributor

benbalter commented Oct 5, 2013

All available lexers for use with the highlight tag are lower case.e This is fine on case-insensitive file systems like OS X, but builds that work locally may fail on linux-based systems, which are case sensitive. (e.g., CSharp may work locally, while it fails on GItHub Pages).

Force lexers to be lower case before passing to Pygments.

@parkr

This comment has been minimized.

Member

parkr commented Oct 5, 2013

👍 @mattr-?

Thanks for the explanation, @benbalter :)

@parkr

This comment has been minimized.

Member

parkr commented Oct 6, 2013

Would you mind quickly adding a test for this?

@benbalter

This comment has been minimized.

Contributor

benbalter commented Oct 6, 2013

Done and done. As an added bonus, it actually works now. 😄

@parkr

This comment has been minimized.

Member

parkr commented Oct 7, 2013

Thank goodness for tests! :) Thanks, Ben!

@mattr-?

@mattr-

This comment has been minimized.

Member

mattr- commented Oct 11, 2013

ba da bing. ba da boom. Merged! 🚢 all the things! ❤️

mattr- added a commit that referenced this pull request Oct 11, 2013

Merge pull request #1615 from benbalter/downcase-lexers
Downcase lexers before passing to Pygments

@mattr- mattr- merged commit 0761769 into jekyll:master Oct 11, 2013

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Oct 11, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.