Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jekyll-import warning note of missing deps. #1626

Merged
merged 5 commits into from Oct 11, 2013

Conversation

Projects
None yet
4 participants
@albertogg
Copy link
Member

albertogg commented Oct 10, 2013

The jekyll-import gem, opted to leave out importer-specific runtime dependencies. I'm adding a warning note for the user to be aware of this and manually install the ones they need based on the importer they are using.

jekyll-import warning note of missing deps.
The jekyll-import gem, opted to leave out importer-specific runtime dependencies. I'm adding a warning note for the user to be aware of this and manually install the ones they need based on the importer they are using.
@parkr

This comment has been minimized.

Copy link
Member

parkr commented Oct 10, 2013

Looks great!

<h5>Jekyll-import needs you to manually install some dependencies.</h5>
<p markdown="1">If you are importing you blog from Drupal 6,7, Joomla,
Mephisto, Mt, Textpattern or Typo (with mysql db), you need to install
`mysql` and `sequel` gem. If you are importing from Wordpress database, you

This comment has been minimized.

Copy link
@parkr

parkr Oct 10, 2013

Member

should it be gems here? and WordPress?

This comment has been minimized.

Copy link
@albertogg

albertogg Oct 10, 2013

Author Member

YES, in all of them.

albertogg added some commits Oct 10, 2013

@@ -24,6 +24,15 @@ Jekyll's standard command line interface.
$ gem install jekyll-import --pre
{% endhighlight %}

<div class="note warning">
<h5>Jekyll-import, requires you to manually install some dependencies.</h5>

This comment has been minimized.

Copy link
@mattr-

mattr- Oct 11, 2013

Member

no comma is needed here.

@@ -24,6 +24,15 @@ Jekyll's standard command line interface.
$ gem install jekyll-import --pre
{% endhighlight %}

<div class="note warning">
<h5>Jekyll-import, requires you to manually install some dependencies.</h5>
<p markdown="1">If you are importing you blog from Drupal 6,7, Joomla,

This comment has been minimized.

Copy link
@mattr-

mattr- Oct 11, 2013

Member

change 'you' to 'your' here, so it reads "If you are importing your blog..."

<div class="note warning">
<h5>Jekyll-import, requires you to manually install some dependencies.</h5>
<p markdown="1">If you are importing you blog from Drupal 6,7, Joomla,
Mephisto, Movable Type, Textpattern or Typo (with mysql db), you need to install

This comment has been minimized.

Copy link
@mattr-

mattr- Oct 11, 2013

Member

Please add a comma before 'or', so that it reads "Textpattern, or Typo"

<h5>Jekyll-import, requires you to manually install some dependencies.</h5>
<p markdown="1">If you are importing you blog from Drupal 6,7, Joomla,
Mephisto, Movable Type, Textpattern or Typo (with mysql db), you need to install
`mysql` and `sequel` gems. If you are importing from WordPress database, you

This comment has been minimized.

Copy link
@mattr-

mattr- Oct 11, 2013

Member

Please add an "a" between "from" and "WordPress", so that it reads "importing from a WordPress database"

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented Oct 11, 2013

Looks very good! Just a fix up a few small nitpicks from me and we'll get this merged! Thanks! 💜

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Oct 11, 2013

Looks great, thank you! ❤️

parkr added a commit that referenced this pull request Oct 11, 2013

Merge pull request #1626 from albertogg/migrations-warning-note
jekyll-import warning note of missing deps.

@parkr parkr merged commit 0ffd4ff into jekyll:master Oct 11, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Oct 11, 2013

@albertogg

This comment has been minimized.

Copy link
Member Author

albertogg commented Oct 11, 2013

Thank you guys! ❤️

@albertogg albertogg deleted the albertogg:migrations-warning-note branch May 26, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.