jekyll-import warning note of missing deps. #1626

Merged
merged 5 commits into from Oct 11, 2013

Projects

None yet

3 participants

@albertogg
Member

The jekyll-import gem, opted to leave out importer-specific runtime dependencies. I'm adding a warning note for the user to be aware of this and manually install the ones they need based on the importer they are using.

@albertogg albertogg jekyll-import warning note of missing deps.
The jekyll-import gem, opted to leave out importer-specific runtime dependencies. I'm adding a warning note for the user to be aware of this and manually install the ones they need based on the importer they are using.
c169ad2
@parkr
Member
parkr commented Oct 10, 2013

Looks great!

@parkr parkr and 1 other commented on an outdated diff Oct 10, 2013
site/docs/migrations.md
@@ -24,6 +24,15 @@ Jekyll's standard command line interface.
$ gem install jekyll-import --pre
{% endhighlight %}
+<div class="note warning">
+ <h5>Jekyll-import needs you to manually install some dependencies.</h5>
+ <p markdown="1">If you are importing you blog from Drupal 6,7, Joomla,
+ Mephisto, Mt, Textpattern or Typo (with mysql db), you need to install
+ `mysql` and `sequel` gem. If you are importing from Wordpress database, you
@parkr
parkr Oct 10, 2013 Member

should it be gems here? and WordPress?

@albertogg
albertogg Oct 10, 2013 Member

YES, in all of them.

@mattr- mattr- commented on an outdated diff Oct 11, 2013
site/docs/migrations.md
@@ -24,6 +24,15 @@ Jekyll's standard command line interface.
$ gem install jekyll-import --pre
{% endhighlight %}
+<div class="note warning">
+ <h5>Jekyll-import, requires you to manually install some dependencies.</h5>
@mattr-
mattr- Oct 11, 2013 Member

no comma is needed here.

@mattr- mattr- commented on an outdated diff Oct 11, 2013
site/docs/migrations.md
@@ -24,6 +24,15 @@ Jekyll's standard command line interface.
$ gem install jekyll-import --pre
{% endhighlight %}
+<div class="note warning">
+ <h5>Jekyll-import, requires you to manually install some dependencies.</h5>
+ <p markdown="1">If you are importing you blog from Drupal 6,7, Joomla,
@mattr-
mattr- Oct 11, 2013 Member

change 'you' to 'your' here, so it reads "If you are importing your blog..."

@mattr- mattr- commented on an outdated diff Oct 11, 2013
site/docs/migrations.md
@@ -24,6 +24,15 @@ Jekyll's standard command line interface.
$ gem install jekyll-import --pre
{% endhighlight %}
+<div class="note warning">
+ <h5>Jekyll-import, requires you to manually install some dependencies.</h5>
+ <p markdown="1">If you are importing you blog from Drupal 6,7, Joomla,
+ Mephisto, Movable Type, Textpattern or Typo (with mysql db), you need to install
@mattr-
mattr- Oct 11, 2013 Member

Please add a comma before 'or', so that it reads "Textpattern, or Typo"

@mattr- mattr- commented on an outdated diff Oct 11, 2013
site/docs/migrations.md
@@ -24,6 +24,15 @@ Jekyll's standard command line interface.
$ gem install jekyll-import --pre
{% endhighlight %}
+<div class="note warning">
+ <h5>Jekyll-import, requires you to manually install some dependencies.</h5>
+ <p markdown="1">If you are importing you blog from Drupal 6,7, Joomla,
+ Mephisto, Movable Type, Textpattern or Typo (with mysql db), you need to install
+ `mysql` and `sequel` gems. If you are importing from WordPress database, you
@mattr-
mattr- Oct 11, 2013 Member

Please add an "a" between "from" and "WordPress", so that it reads "importing from a WordPress database"

@mattr-
Member
mattr- commented Oct 11, 2013

Looks very good! Just a fix up a few small nitpicks from me and we'll get this merged! Thanks! 💜

@parkr
Member
parkr commented Oct 11, 2013

Looks great, thank you! ❤️

@parkr parkr merged commit 0ffd4ff into jekyll:master Oct 11, 2013

1 check passed

default The Travis CI build passed
Details
@parkr parkr added a commit that referenced this pull request Oct 11, 2013
@parkr parkr Update history to reflect merge of #1626 6f79358
@albertogg
Member

Thank you guys! ❤️

@albertogg albertogg deleted the albertogg:migrations-warning-note branch May 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment