New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build status badge in README refers to master branch. #1636

Merged
merged 1 commit into from Oct 17, 2013

Conversation

Projects
None yet
5 participants
@pda
Contributor

pda commented Oct 16, 2013

Otherwise, experimental branches being pushed can cause the badge
in the README (master branch, GitHub repo page) to show the build
failing.

Build status badge in README refers to master branch.
Otherwise, experimental branches being pushed can cause the badge
in the README (master branch, GitHub front page) to show the build
failing.
@kelvinst

This comment has been minimized.

kelvinst commented Oct 16, 2013

Hm, fair enough in my opinion... @parkr ?

@parkr

This comment has been minimized.

Member

parkr commented Oct 17, 2013

What happens if it doesn't have that branch declaration? Latest build?

@pda

This comment has been minimized.

Contributor

pda commented Oct 17, 2013

It appears to be.

It's currently showing “build failing” because the very latest build 2019 (multiple-sources branch) failed, despite the previous build 2018 (master branch) having passed.

@mattr-

This comment has been minimized.

Member

mattr- commented Oct 17, 2013

👍 from me.

mattr- added a commit that referenced this pull request Oct 17, 2013

Merge pull request #1636 from pda/patch-1
Build status badge in README refers to master branch.

@mattr- mattr- merged commit 1682dc8 into jekyll:master Oct 17, 2013

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Oct 17, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.