New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Site#render #1638

Merged
merged 3 commits into from Oct 17, 2013

Conversation

Projects
None yet
3 participants
@maul-esel
Contributor

maul-esel commented Oct 17, 2013

Shorten and simplify the code in Site#render, removing duplication.

@@ -389,7 +386,7 @@ def aggregate_post_info(post)
end
def relative_permalinks_deprecation_method
if config['relative_permalinks'] && !@deprecated_relative_permalinks
if config['relative_permalinks'] && self.pages.any? { |page| page.uses_relative_permalinks }

This comment has been minimized.

@mattr-

mattr- Oct 17, 2013

Member

I think self.pages.any? { |page| page.uses_relative_permalinks } could use its own method.

@mattr-

This comment has been minimized.

Member

mattr- commented Oct 17, 2013

One tiny little nitpick, but 👍

@maul-esel

This comment has been minimized.

Contributor

maul-esel commented Oct 17, 2013

@mattr- Done!

@mattr-

This comment has been minimized.

Member

mattr- commented Oct 17, 2013

❤️

mattr- added a commit that referenced this pull request Oct 17, 2013

@mattr- mattr- merged commit 1fd549c into jekyll:master Oct 17, 2013

1 check was pending

default The Travis CI build is in progress
Details

@maul-esel maul-esel deleted the maul-esel:render-page-or-post branch Oct 17, 2013

mattr- added a commit that referenced this pull request Oct 17, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.