New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Listen implementation so master is compatible with 1.8.7 #1665

Merged
merged 3 commits into from Oct 28, 2013

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Oct 28, 2013

  • remove Ruby >= 1.9.x hash syntax
  • no newlines between
  • allow listen ~> 1.3. changelog from v1.3.0 to v1.3.1. In case new versions are released that are critical in v1.x, it'd be nice to allow it.
@parkr

This comment has been minimized.

Member

parkr commented Oct 28, 2013

Once rest-client/rest-client#240 is merged, we won't need 0c2d7c0

@mattr-

This comment has been minimized.

Member

mattr- commented Oct 28, 2013

Thank you! Thank you! Thank you! ❤️ ❤️ ❤️

mattr- added a commit that referenced this pull request Oct 28, 2013

Merge pull request #1665 from mojombo/downgrade-listen
Fix Listen implementation so master is compatible with 1.8.7

@mattr- mattr- merged commit bca4d37 into master Oct 28, 2013

1 check passed

default The Travis CI build passed
Details

@mattr- mattr- deleted the downgrade-listen branch Oct 28, 2013

@parkr

This comment has been minimized.

Member

parkr commented Oct 28, 2013

My pleasure! ❤️

mattr- added a commit that referenced this pull request Oct 28, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.