New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table_prefix option for jekyll-importer #1669

Merged
merged 2 commits into from Nov 11, 2013

Conversation

Projects
None yet
4 participants
@albertogg
Member

albertogg commented Oct 29, 2013

Add database table_prefix to use with WordPress and Joomla importers so they can modify the default value.

Add table_prefix option for jekyll-importer
Add table_prefix to use with WordPress and Joomla importers so they can modify the default value.
@parkr

This comment has been minimized.

Member

parkr commented Oct 29, 2013

LGTM! @mattr-?

@parkr

This comment has been minimized.

Member

parkr commented Nov 5, 2013

What do you think about just --prefix instead of --table_prefix? It's more generic and can be used for Drupal, too.

@mattr-

This comment has been minimized.

Member

mattr- commented Nov 5, 2013

I'm 👍 on --prefix

@albertogg

This comment has been minimized.

Member

albertogg commented Nov 6, 2013

if we use --prefix do we have to change the WordPress and Joomla importers to read :prefix instead of :table_prefix? I know it's a dumb question but idk.

@parkr

This comment has been minimized.

Member

parkr commented Nov 6, 2013

Yeah, we'd have to change those.

@albertogg

This comment has been minimized.

Member

albertogg commented Nov 6, 2013

Ok, I'll change both! 


Sent from Mailbox for iPhone

On Wed, Nov 6, 2013 at 12:24 AM, Parker Moore notifications@github.com
wrote:

Yeah, we'd have to change those.

Reply to this email directly or view it on GitHub:
#1669 (comment)

@albertogg

This comment has been minimized.

Member

albertogg commented Nov 7, 2013

Done!

@parkr

This comment has been minimized.

Member

parkr commented Nov 7, 2013

I'm 👍 on this.

@mattr- is this a 1.3.1 change or a 1.4 change?

@mattr-

This comment has been minimized.

Member

mattr- commented Nov 7, 2013

1.3.1 change. Hoping we can get a jekyll-import gem out there soon.

@parkr

This comment has been minimized.

Member

parkr commented Nov 7, 2013

@mattr- I'm working a lot on it at the moment, so we should be good to go very soon.

@albertogg

This comment has been minimized.

Member

albertogg commented Nov 7, 2013

@parkr I think this will depend on how long your number 69 pull request on jekyll-import will take to get merged.


Sent from Mailbox for iPhone

On Thu, Nov 7, 2013 at 5:36 PM, Parker Moore notifications@github.com
wrote:

I'm 👍 on this.

@mattr- is this a 1.3.1 change or a 1.4 change?

Reply to this email directly or view it on GitHub:
#1669 (comment)

@albertogg

This comment has been minimized.

Member

albertogg commented Nov 7, 2013

Nice, I'm available for help if you both need me!


Sent from Mailbox for iPhone

On Thu, Nov 7, 2013 at 5:48 PM, Parker Moore notifications@github.com
wrote:

@mattr- I'm working a lot on it at the moment, so we should be good to go very soon.

Reply to this email directly or view it on GitHub:
#1669 (comment)

mattr- added a commit that referenced this pull request Nov 11, 2013

Merge pull request #1669 from albertogg/jekyll-import-arguments
Add table_prefix option for jekyll-importer

@mattr- mattr- merged commit 99d44d2 into jekyll:master Nov 11, 2013

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Nov 11, 2013

csim added a commit to csim/jekyll that referenced this pull request Nov 11, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.