Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix variable include tag in a loop #1726

Merged
merged 2 commits into from Nov 15, 2013

Conversation

Projects
None yet
5 participants
@maul-esel
Copy link
Contributor

maul-esel commented Nov 14, 2013

This PR fixes the BUG found by @jedfoster and @floatingboxes and reported here.

maul-esel added some commits Nov 14, 2013

fix include tag: don't store variable value
This fixes the bug reported in #1495 (comments).
@parkr

This comment has been minimized.

Copy link
Member

parkr commented Nov 14, 2013

I only see the test right now. Are you working on a fix?

@maul-esel

This comment has been minimized.

Copy link
Contributor Author

maul-esel commented Nov 14, 2013

Yes, coming right up 😉

@maul-esel

This comment has been minimized.

Copy link
Contributor Author

maul-esel commented Nov 14, 2013

OK, fix is there and the last and slowest Travis build has completed and passed. Ready to go!

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Nov 14, 2013

LGTM. @mattr-?

mattr- added a commit that referenced this pull request Nov 15, 2013

Merge pull request #1726 from maul-esel/include-fix
fix variable include tag in a loop

@mattr- mattr- merged commit e0ef667 into jekyll:master Nov 15, 2013

1 check passed

default The Travis CI build passed
Details
@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented Nov 15, 2013

Thanks @maul-esel!! 👍

@maul-esel maul-esel deleted the maul-esel:include-fix branch Nov 15, 2013

mattr- added a commit that referenced this pull request Nov 15, 2013

@floatingboxes

This comment has been minimized.

Copy link

floatingboxes commented Nov 15, 2013

Big thank you @maul-esel!

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Nov 15, 2013

🎉 👍

csim added a commit to csim/jekyll that referenced this pull request Nov 22, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.