Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix duplicate test case name #1754

Merged
merged 1 commit into from

3 participants

@gregkare

Extracted from #1733

It doesn't crash with shoulda-context 1.0.2 (I had to update to 1.1.6 in my PR for Rubinius), so this test was probably not even run before because of the duplication. shoulda-context now raises an exception: https://github.com/thoughtbot/shoulda-context/blob/master/lib/shoulda/context/context.rb#L392-L394

And here's the issue that added the exceptions on duplicate test name: thoughtbot/shoulda-context#26

@parkr
Owner

LGTM. @mattr-?

@gregkare

I probably wasn't clear enough: it's obviously a copy and paste error, the test case refers to the post as "complex" while it's indeed "nested". :)

https://github.com/gregkare/jekyll/blob/9182b1b7ae75f3aeef3668cd7131ca53b16ca868/test/test_tags.rb#L229-L236

@parkr
Owner

Yep, I got that. Thanks!

@mattr- mattr- merged commit cbfb4e7 into jekyll:master
@mattr-
Owner

Nice catch!

@mattr- mattr- referenced this pull request from a commit
@mattr- mattr- Update history to reflect merge of #1754 47eac96
@gregkare gregkare deleted the unknown repository branch
@gregkare gregkare referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 25, 2013
  1. @gregkare

    Fix duplicate test case name

    gregkare authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  test/test_tags.rb
View
2  test/test_tags.rb
@@ -226,7 +226,7 @@ def fill_post(code, override = {})
assert_no_match /markdown\-html\-error/, @result
end
- should "have the url to the \"nested\" post from 2008-11-21" do
+ should "have the url to the \"complex\" post from 2008-11-21" do
assert_match %r{1\s/2008/11/21/complex/}, @result
assert_match %r{2\s/2008/11/21/complex/}, @result
end
Something went wrong with that request. Please try again.