New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate test case name #1754

Merged
merged 1 commit into from Nov 26, 2013

Conversation

Projects
None yet
4 participants
@gregkare
Contributor

gregkare commented Nov 25, 2013

Extracted from #1733

It doesn't crash with shoulda-context 1.0.2 (I had to update to 1.1.6 in my PR for Rubinius), so this test was probably not even run before because of the duplication. shoulda-context now raises an exception: https://github.com/thoughtbot/shoulda-context/blob/master/lib/shoulda/context/context.rb#L392-L394

And here's the issue that added the exceptions on duplicate test name: thoughtbot/shoulda-context#26

@parkr

This comment has been minimized.

Member

parkr commented Nov 25, 2013

LGTM. @mattr-?

@gregkare

This comment has been minimized.

Contributor

gregkare commented Nov 25, 2013

I probably wasn't clear enough: it's obviously a copy and paste error, the test case refers to the post as "complex" while it's indeed "nested". :)

https://github.com/gregkare/jekyll/blob/9182b1b7ae75f3aeef3668cd7131ca53b16ca868/test/test_tags.rb#L229-L236

@parkr

This comment has been minimized.

Member

parkr commented Nov 25, 2013

Yep, I got that. Thanks!

mattr- added a commit that referenced this pull request Nov 26, 2013

@mattr- mattr- merged commit cbfb4e7 into jekyll:master Nov 26, 2013

@mattr-

This comment has been minimized.

Member

mattr- commented Nov 26, 2013

Nice catch!

mattr- added a commit that referenced this pull request Nov 26, 2013

@gregkare gregkare deleted the gregkare:duplicate_testcase branch Nov 26, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.