Fix duplicate test case name #1754

Merged
merged 1 commit into from Nov 26, 2013

Projects

None yet

3 participants

@gregkare
Contributor

Extracted from #1733

It doesn't crash with shoulda-context 1.0.2 (I had to update to 1.1.6 in my PR for Rubinius), so this test was probably not even run before because of the duplication. shoulda-context now raises an exception: https://github.com/thoughtbot/shoulda-context/blob/master/lib/shoulda/context/context.rb#L392-L394

And here's the issue that added the exceptions on duplicate test name: thoughtbot/shoulda-context#26

@parkr
Member
parkr commented Nov 25, 2013

LGTM. @mattr-?

@gregkare
Contributor

I probably wasn't clear enough: it's obviously a copy and paste error, the test case refers to the post as "complex" while it's indeed "nested". :)

https://github.com/gregkare/jekyll/blob/9182b1b7ae75f3aeef3668cd7131ca53b16ca868/test/test_tags.rb#L229-L236

@parkr
Member
parkr commented Nov 25, 2013

Yep, I got that. Thanks!

@mattr- mattr- merged commit cbfb4e7 into jekyll:master Nov 26, 2013
@mattr-
Member
mattr- commented Nov 26, 2013

Nice catch!

@mattr- mattr- added a commit that referenced this pull request Nov 26, 2013
@mattr- mattr- Update history to reflect merge of #1754 47eac96
@gregkare gregkare deleted the unknown repository branch Nov 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment