New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor post and draft object creation #1779

Merged
merged 2 commits into from Dec 7, 2013

Conversation

Projects
None yet
4 participants
@mattr-
Member

mattr- commented Dec 6, 2013

De-duplicate object creation between posts and drafts. Inject the name
dependency through a parameter

@mattr-

This comment has been minimized.

Member

mattr- commented Dec 6, 2013

/cc @pzula because she helped. 😃

@parkr

This comment has been minimized.

Member

parkr commented Dec 6, 2013

@mattr-

This comment has been minimized.

Member

mattr- commented Dec 6, 2013

LOL!! didn't even think about that.

On Thu, Dec 5, 2013 at 11:28 PM, Parker Moore notifications@github.com
wrote:

Fails big time in 1.8.7

Reply to this email directly or view it on GitHub:
#1779 (comment)

@parkr

This comment has been minimized.

Member

parkr commented Dec 6, 2013

One of the main reasons I ❤️ continuous integration. If it had the green light, I definitely would have merged!

For reference, the error:

NoMethodError: undefined method `each_with_object' for #Array:0x7f2424e91688

@mattr-

This comment has been minimized.

Member

mattr- commented Dec 6, 2013

😭

@pzula

This comment has been minimized.

Contributor

pzula commented Dec 6, 2013

@mattr- Can we move back to using just plain each again and shoveling into an empty array?

@pzula

This comment has been minimized.

Contributor

pzula commented Dec 6, 2013

@mattr- Actually, I'm going to give good ol' map a try and rerun the tests, and see what TravisCI has to say about it

@pzula

This comment has been minimized.

Contributor

pzula commented Dec 6, 2013

@mattr- I've changed our enumerator and the tests all pass. However, I've never tried to update a PR before that was not my own... I have made the code changes in my fork here: pzula@440d3fd but am unsure as to how to add it to this pull request? Do I open a new request?

@parkr

This comment has been minimized.

Member

parkr commented Dec 6, 2013

@pzula Cherry-picked your commit into this branch. All set!

mattr- and others added some commits Dec 6, 2013

Refactor post and draft object creation
De-duplicate object creation between posts and drafts. Inject the name
dependency through a parameter
@parkr

This comment has been minimized.

Member

parkr commented Dec 6, 2013

The failures I saw from the previous push were re: TOML stuff which I already fixed on master so I did a force push (heh).

Now watching this build closely...

mattr- added a commit that referenced this pull request Dec 7, 2013

Merge pull request #1779 from mojombo/no-duplication
Refactor post and draft object creation

@mattr- mattr- merged commit 362d28f into master Dec 7, 2013

@mattr- mattr- deleted the no-duplication branch Dec 7, 2013

mattr- added a commit that referenced this pull request Dec 7, 2013

aggregate_post_info(post)
end
posts.each do |post|
if post.published && (self.future || post.date <= self.time)

This comment has been minimized.

@parkr

parkr Dec 9, 2013

Member

Is this supposed to be post.published?

This comment has been minimized.

@mattr-

mattr- Dec 9, 2013

Member

does published? do the same thing as published (without the question mark)? (this is rhetorical, I'll answer this myself)

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.