Implement group_by Liquid filter & tests. #1788

Merged
merged 2 commits into from Dec 10, 2013

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Dec 8, 2013

Supercedes #1738.

lib/jekyll/filters.rb
+ if item.respond_to?(:data)
+ item.data[property.to_s].to_s
+ else
+ item[property.to_s].to_s

This comment has been minimized.

Show comment Hide comment
@mattr-

mattr- Dec 9, 2013

Member

Perhaps this

if item.respond_to?(:data)
 item.data[property.to_s].to_s
else
 item[property.to_s].to_s
end

gets it's own property_data(property) method?

@mattr-

mattr- Dec 9, 2013

Member

Perhaps this

if item.respond_to?(:data)
 item.data[property.to_s].to_s
else
 item[property.to_s].to_s
end

gets it's own property_data(property) method?

This comment has been minimized.

Show comment Hide comment
@parkr

parkr Dec 9, 2013

Member

I was just thinking that!

@parkr

parkr Dec 9, 2013

Member

I was just thinking that!

@mattr-

This comment has been minimized.

Show comment Hide comment
@mattr-

mattr- Dec 9, 2013

Member

Just the one question but 👍 otherwise.

Member

mattr- commented Dec 9, 2013

Just the one question but 👍 otherwise.

@parkr parkr merged commit a70726e into master Dec 10, 2013

parkr added a commit that referenced this pull request Dec 10, 2013

@parkr parkr deleted the group-by-filter-2 branch Dec 10, 2013

@mattr-

This comment has been minimized.

Show comment Hide comment
@mattr-

mattr- Dec 11, 2013

Member

❤️

Member

mattr- commented Dec 11, 2013

❤️

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.