Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unminify css #1803

Merged
merged 2 commits into from Dec 10, 2013

Conversation

Projects
None yet
5 participants
@doktorbro
Copy link
Member

doktorbro commented Dec 10, 2013

This commit helps @cobyism to find CSS pieces in the concatenated file.

Ref: #1777 (comment)

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Dec 10, 2013

GitHub Pages sets site.GH_ENV when it runs Jekyll. Can we use this to either capture & minify, or not? Also, printing the name of the file above the include as a comment might help in dev mode :)

@cobyism

This comment has been minimized.

Copy link
Member

cobyism commented Dec 10, 2013

I appreciate the sentiment and effort, but honestly, don’t undo stuff just because of my comment. I’m not really involved in maintaining this site, so it’s far better to go off what makes practical sense for the maintainers. The problem of not knowing where the CSS is coming is just like the problem of the CSS needing to be optimized in the first place—they both seem like small problems in the grand scheme of things, so I’d just pick one way or the other and go with it.

@doktorbro

This comment has been minimized.

Copy link
Member Author

doktorbro commented Dec 10, 2013

Can we use this to either capture & minify, or not?

Yes, it’s done.

@cobyism The environment constant will make everybody happy.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Dec 10, 2013

Love it!

@mattr-?

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented Dec 10, 2013

:shipit:

@parkr parkr merged commit a1efc10 into jekyll:master Dec 10, 2013

parkr added a commit that referenced this pull request Dec 10, 2013

@doktorbro doktorbro deleted the doktorbro:site-unminify-css branch Dec 11, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.