New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `path` to required methods #1866

Merged
merged 1 commit into from Dec 26, 2013

Conversation

Projects
None yet
3 participants
@colindean
Contributor

colindean commented Dec 23, 2013

The error messages in this module call #path, but the module does not require the path method to be implemented. This change documents that classes which include Convertible must define path.

See #1846 for discussion.

Add `path` to required methods
The error messages in this module call `#path`, but the module does not require the `path` method to be implemented. This change documents that classes which include `Convertible` must define `path`.

See #1846 for discussion.
@colindean

This comment has been minimized.

Contributor

colindean commented Dec 23, 2013

Wait, shouldn't Jekyll::Layout then have to implement this method in some way? At least some of the other require methods are implemented with just attr_accessor.

jekyll-haml just (unwisely) opens up Jekyll::Layout to add a self.transform to the #initialize method.

parkr added a commit that referenced this pull request Dec 26, 2013

@parkr parkr merged commit ebaa484 into jekyll:master Dec 26, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Dec 26, 2013

@colindean colindean deleted the colindean:patch-2 branch May 8, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.