New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump safe_yaml version to 1.0.0 #1886

Merged
merged 1 commit into from Dec 28, 2013

Conversation

Projects
None yet
4 participants
@ivantsepp
Contributor

ivantsepp commented Dec 28, 2013

See #1845

The problem is that safe_yaml parses time into UTC. Specially, there was a front-matter data for date which was 2009-06-02T01:48:00+05:30. This was converted to 2009-06-01 20:18:00 UTC by this line. That's why it couldn't find the post; the day on the filename didn't match the day on the post data.

It seems that this has been fixed in the most recent version of safe_yaml: see dtao/safe_yaml#35.

I bumped the version and I've gotten @spinningarrow's Jekyll repository to build. I'm not sure if I need to add tests. But let me know if I should!

@parkr

This comment has been minimized.

Member

parkr commented Dec 28, 2013

This looks great! Would you make it ~> 1.0 instead of ~> 1.0.0? We only include PATCH for anything < 1.0. :) Thanks!

@parkr parkr referenced this pull request Dec 28, 2013

Closed

Update safe_yaml dependency #1884

parkr added a commit that referenced this pull request Dec 28, 2013

@parkr parkr merged commit 3e4d47c into jekyll:master Dec 28, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Dec 28, 2013

parkr added a commit that referenced this pull request Dec 28, 2013

@andrewbeesides

This comment has been minimized.

andrewbeesides commented Nov 3, 2014

Hey all, I'm seeing this issue again. I'm new here so I apologize in advance if I am not giving the appropriate information up front.

Liquid Exception: Could not find post "2014-07-11-korea-7-10-2014" in tag 'post_url'. Make sure the post exists and the name is correct. in _posts/2014-08-22-ye-olde-korea-trip-recap.markdown
jekyll 2.4.0 | Error:  Could not find post "2014-07-11-korea-7-10-2014" in tag 'post_url'.

The pertinent parts of the post's front matter read:

title: "Korea 7/10/2014"
date: 2014-07-11 01:15:00

I've added the following to my _config.yml as well: timezone: America/Los_Angeles

I can access the file at 2014/07/10/korea-7-10-2014.html which reveals to me that timezone shenanigans is to blame.

In the meantime, I can change my post_url tags to use the "changed filename" but would love to see a long-term fix. Let me know if you need more information from me. Thanks!

$ ruby -v
ruby 2.1.4p265 (2014-10-27 revision 48166) [x86_64-darwin14.0]
$ jekyll -v
jekyll 2.4.0
$ gem -v safe_yaml
2.2.2

EDIT: Turns out I can't use the "changed filename" (project fails to deploy due to GitHub Pages build error). I suspect the timezone isn't honored locally but is on the server? Hard to say...so I ended up setting permalinks for my posts and referring to those instead.

@parkr

This comment has been minimized.

Member

parkr commented Nov 3, 2014

In Jekyll 3.0, our post_url should really check against the slug of the post not the date we hold in memory (no Time objects!)

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.