New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kramdown to 1.3 #1894

Merged
merged 1 commit into from Dec 31, 2013

Conversation

Projects
None yet
4 participants
@CHH
Contributor

CHH commented Dec 30, 2013

Hi I've an existing Jekyll site which I want to convert to using Kramdown (mainly for its footnote support), but it converts line breaks into <br> which is not intended, and it would be time consuming to change all posts to remove the right line breaks.

Since 1.3.0 there is an option in Kramdown to turn this off (hard_wrap), but Jekyll enforces 1.2.0 so this option is not available there. Would be cool if Kramdown could be updated to 1.3.0, AFAIK there were no BC breaks introduced (http://kramdown.gettalong.org/news.html).

@mattr-

This comment has been minimized.

Member

mattr- commented Dec 30, 2013

Do you need this for a GitHub Pages site or are you hosting it yourself (either via S3 or Heroku or some other such thing)?

@CHH

This comment has been minimized.

Contributor

CHH commented Dec 30, 2013

@mattr- forgot to say, this was github/pages-gem#37 before and the site is built via GitHub pages.

So locally I've just put gem "kramdown", "~>1.3" in my Gemfile and set hard_wrap: false in my Kramdown options and everything works as expected, but on GitHub pages it doesn't work.

@CHH

This comment has been minimized.

Contributor

CHH commented Dec 30, 2013

OK, this won't be necessary. This is an issue for the pages-gem.

@CHH CHH closed this Dec 30, 2013

@mattr-

This comment has been minimized.

Member

mattr- commented Dec 30, 2013

Actually, I'd like to keep this around, since Kramdown is a development dependency of Jekyll. I'd like to make sure we're testing on the latest release.

@mattr- mattr- reopened this Dec 30, 2013

@ghost ghost assigned parkr Dec 30, 2013

@mattr-

This comment has been minimized.

Member

mattr- commented Dec 30, 2013

LGTM, btw. Want to get @parkr to stamp his seal of approval as well. 😃

parkr added a commit that referenced this pull request Dec 31, 2013

@parkr parkr merged commit a8a7f03 into jekyll:master Dec 31, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Dec 31, 2013

@parkr

This comment has been minimized.

Member

parkr commented Dec 31, 2013

It doesn't really make a difference in terms of Travis CI (it'll always use the very latest version we ask for as it starts each build with a fresh slate) but may as well!

@CHH CHH deleted the CHH:patch-1 branch Dec 31, 2013

@CHH

This comment has been minimized.

Contributor

CHH commented Dec 31, 2013

Thanks all!

@zdroid zdroid referenced this pull request Feb 18, 2014

Closed

Wrong section? #2069

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.