New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --quiet flag #1898

Merged
merged 1 commit into from Jan 4, 2014

Conversation

Projects
None yet
4 participants
@ahazem
Contributor

ahazem commented Jan 1, 2014

Hi,

Implements #1764.

I noticed that running rake test returns a failure:

[ 93/311] TestGeneratedSite#test: generated sites should ensure post count is as expected.  = 0.23 s
  1) Failure:
test: generated sites should ensure post count is as expected. (TestGeneratedSite) [/users/*****/desktop/dev/oss/jekyll/test/test_generated_site.rb:17]:
<37> expected but was
<38>.

Apparently the test is failing because a2fd8ba added a file (named 2013-12-20-properties.text) in source/_posts directory without adjusting the number to 38. However, I thought I would leave this up to you guys to change.

@parkr

This comment has been minimized.

Member

parkr commented Jan 1, 2014

👍 from meh. @mattr-?

@parkr

This comment has been minimized.

Member

parkr commented Jan 2, 2014

@ahazem The error you mention there should be fixed upstream. Mind rebasing for me?

@ahazem

This comment has been minimized.

Contributor

ahazem commented Jan 2, 2014

@parkr done. :)

@parkr

This comment has been minimized.

Member

parkr commented Jan 2, 2014

Did you force push? Still seeing the same error in Travis.

@ahazem

This comment has been minimized.

Contributor

ahazem commented Jan 2, 2014

Hmm, I did. I'm not an expert but could it possibly be that you need to restart that build? The details on travis shows that the build finished yesterday.

@ghost ghost assigned mattr- Jan 2, 2014

parkr added a commit that referenced this pull request Jan 4, 2014

@parkr parkr merged commit 35948fa into jekyll:master Jan 4, 2014

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jan 4, 2014

@parkr parkr referenced this pull request Mar 25, 2014

Closed

Add --quiet flag #1764

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.