New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump safe_yaml to ~> 1.0.0 #1942

Merged
merged 1 commit into from Jan 22, 2014

Conversation

Projects
None yet
3 participants
@mattr-
Member

mattr- commented Jan 13, 2014

Be more strict about what versions we'll take, since this is the stable
branch.

This fixes #1792 for the 1.4.x series of releases.

Bump safe_yaml to ~> 1.0.0
Be more strict about what versions we'll take, since this is the stable
branch
@@ -29,7 +29,7 @@ Gem::Specification.new do |s|
s.add_runtime_dependency('maruku', "~> 0.7.0")
s.add_runtime_dependency('pygments.rb', "~> 0.5.0")
s.add_runtime_dependency('commander', "~> 4.1.3")
s.add_runtime_dependency('safe_yaml', "~> 0.9.7")
s.add_runtime_dependency('safe_yaml', "~> 1.0.0")

This comment has been minimized.

@parkr

parkr Jan 13, 2014

Member

Is ~> 1.0 a no-go?

This comment has been minimized.

@mattr-

mattr- Jan 13, 2014

Member

It's ~1.0 in master which will download a 1.1 once it's released. I didn't like that idea for a stable branch that's supposed to be relatively stable. So I locked it to 1.0.x. Do we want to let Jekyll 1.x float on safe_yaml 1.x?

This comment has been minimized.

@parkr

parkr Jan 14, 2014

Member

As long as 1.x has 1.8.7 support. 1.0.x is probably safer, so I'm 👍 with it as-is as long as the tests can be fixed.

This comment has been minimized.

@mattr-

mattr- Jan 14, 2014

Member

Ok. Might take a few more days. I have to dust off the VM with 1.8.7 on it.

@ghost ghost assigned mattr- Jan 14, 2014

@parkr

This comment has been minimized.

Member

parkr commented Jan 22, 2014

1.0.x has 1.8.7 support! Ready to ship this.

parkr added a commit that referenced this pull request Jan 22, 2014

@parkr parkr merged commit a7cec73 into v1-stable Jan 22, 2014

1 check failed

default The Travis CI build failed
Details
@mattr-

This comment has been minimized.

Member

mattr- commented Jan 22, 2014

❤️ 🎉

parkr added a commit that referenced this pull request Jan 22, 2014

parkr added a commit that referenced this pull request Jan 22, 2014

@parkr parkr deleted the v1-stable-safe-yaml-update branch Mar 25, 2014

@parkr parkr added the Enhancement label Mar 25, 2014

@parkr parkr referenced this pull request Mar 25, 2014

Merged

Release v1.5.0 #2168

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.