Patch show-stopping security vulnerabilities #1944
Merged
Conversation
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
parkr
added a commit
that referenced
this pull request
Jan 14, 2014
parkr
added a commit
that referenced
this pull request
Jan 14, 2014
This comment has been minimized.
This comment has been minimized.
Have you test this on windows?
|
This comment has been minimized.
This comment has been minimized.
the result of |
This comment has been minimized.
This comment has been minimized.
Yep, we're aware of this problem (#1948). Basically what we're trying to do is this:
Goal: Don't allow any URL's to be outside the destination directory. This fix works for unix systems where |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Two vulnerabilities found:
Post#destination
allows path traversal due to theCGI.unescape
called prior to the post URL being used in the generation of the output file path. URL escaped characters can be used in a permalink to bypass the filtering provided byURL#sanitize_url
. (@gregose)_includes
. (@charliesome)GitHub Pages has already been patched. It is strongly recommended that any other Jekyll hosts upgrade to v1.4.3 when it lands (tonight).