Patch show-stopping security vulnerabilities #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
ghost
assigned
parkr
added a commit
that referenced
this pull request
Jan 14, 2014
parkr
added a commit
that referenced
this pull request
Jan 14, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two vulnerabilities found:
Post#destinationallows path traversal due to theCGI.unescapecalled prior to the post URL being used in the generation of the output file path. URL escaped characters can be used in a permalink to bypass the filtering provided byURL#sanitize_url. (@gregose)_includes. (@charliesome)GitHub Pages has already been patched. It is strongly recommended that any other Jekyll hosts upgrade to v1.4.3 when it lands (tonight).