Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Made Jekyll serve IPv6 compatible by Default [mojombo:master => jekyll:master] #1981

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants

donatj commented Jan 23, 2014

This is a fixed version of this pull request which was pointing at mojombo:master.

It contains a one line change to make Jekyll server IPv6 compatible by default.

@mattr- approved of it, but requested I repost the pull request.

Owner

mattr- commented Jan 23, 2014

I'm still in the process of making the IPv6 changes to my network. Hopefully soon, I can test this out.

donatj commented Jan 23, 2014

Comcast in my area had IPv6 but dropped it, hopefully it'll be coming back soon. You should be able to test http://[::1]:4000 as a local loopback regardless of hardware.

Owner

parkr commented Jan 24, 2014

What OS/system configs does this require?

Member

troyswanson commented Jan 24, 2014

In theory it should work with anything, but it definitely should be tested as much as possible - especially on Windows rigs - before being merged. I already did some tests on OS X in #1595 and it works like a champ there.

Owner

parkr commented Jan 24, 2014

@troyswanson Thanks for checking. Which OS X version were you using?

I'd like to make sure this runs on all major distros of Linux, Mac OS X 10.7 and above, and Windows Vista, 7 & 8 before merging. We can't break the default server with a technology that hasn't been fully adopted yet by COTS machines.

I'm also not convinced that "this not being enabled by default is a bug." (#1594 (comment)) Could you elaborate on this?

Member

troyswanson commented Jan 24, 2014

@parkr I was on Mountain Lion when I tested that. I'm on Mavericks now and will test again in bit.

donatj commented Jan 24, 2014

Well XP doesn't support IPv6 out of the box and has to be installed - see: http://support.microsoft.com/kb/2478747

Does Jekyll officially support XP?

Owner

parkr commented Jan 24, 2014

@donatj No, I only listed Vista, 7 & 8 in my comment above.

Contributor

XhmikosR commented Jan 24, 2014

If one can point me to instructions how to test this I can try how it behaves on Windows.

Owner

parkr commented Jan 24, 2014

@XhmikosR Sure! Do this:

  1. Clone git://github.com/donatj/jekyll.git & enter into the directory
  2. Run bundle install to download and install all dependencies
  3. Go to the site directory
  4. Run ..\bin\jekyll serve
  5. Can you see the Jekyll docs site on localhost:4000?
Contributor

XhmikosR commented Jan 24, 2014

OK, it works with localhost:4000, but doesn't work with http://127.0.0.1:4000/ anymore which works up until 1.4.2.

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.

C:\Users\xmr\Desktop\jekyll\site>ruby --version
ruby 1.9.3p484 (2013-11-22) [i386-mingw32]

C:\Users\xmr\Desktop\jekyll\site>@CHCP 65001
Active code page: 65001

C:\Users\xmr\Desktop\jekyll\site>SET PATH=C:\Python27;C:\Python27\Scripts;%PATH%

C:\Users\xmr\Desktop\jekyll\site>ruby ..\bin\jekyll serve
Configuration file: C:/Users/xmr/Desktop/jekyll/site/_config.yml
            Source: C:/Users/xmr/Desktop/jekyll/site
       Destination: C:/Users/xmr/Desktop/jekyll/site/_site
      Generating...
 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "" for md_link("#1339", "")
| Available refs are ["1339", "1338", "1321", "github release", "gh_pages", "v1_
1_0"]
+---------------------------------------------------------------------------
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:657:in `to_html_link'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:891:in `block in array_to_html'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `each'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `array_to_html'
\___________________________________________________________________________

Not creating a link for ref_id = "".


 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "" for md_link("#1338", "")
| Available refs are ["1339", "1338", "1321", "github release", "gh_pages", "v1_
1_0"]
+---------------------------------------------------------------------------
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:657:in `to_html_link'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:891:in `block in array_to_html'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `each'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `array_to_html'
\___________________________________________________________________________

Not creating a link for ref_id = "".


 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "#1321" for md_link("strange excerpt bug in v1.1.0", "
#1321")
| Available refs are ["1339", "1338", "1321", "github release", "gh_pages", "v1_
1_0"]
+---------------------------------------------------------------------------
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:657:in `to_html_link'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:891:in `block in array_to_html'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `each'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `array_to_html'
\___________________________________________________________________________

Not creating a link for ref_id = "#1321".


 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "" for md_link("#1339", "")
| Available refs are ["1339", "1338", "1321", "github release", "gh_pages", "v1_
1_0"]
+---------------------------------------------------------------------------
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:657:in `to_html_link'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:891:in `block in array_to_html'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `each'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `array_to_html'
\___________________________________________________________________________

Not creating a link for ref_id = "".


 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "" for md_link("#1338", "")
| Available refs are ["1339", "1338", "1321", "github release", "gh_pages", "v1_
1_0"]
+---------------------------------------------------------------------------
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:657:in `to_html_link'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:891:in `block in array_to_html'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `each'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `array_to_html'
\___________________________________________________________________________

Not creating a link for ref_id = "".


 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "#1321" for md_link("strange excerpt bug in v1.1.0", "
#1321")
| Available refs are ["1339", "1338", "1321", "github release", "gh_pages", "v1_
1_0"]
+---------------------------------------------------------------------------
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:657:in `to_html_link'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:891:in `block in array_to_html'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `each'
!C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/maruku-0.7.1/lib/maruku/ou
tput/to_html.rb:879:in `array_to_html'
\___________________________________________________________________________

Not creating a link for ref_id = "#1321".

C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/posix-spawn-0.3.8/lib/posix
/spawn.rb:162: warning: cannot close fd before spawn
'which' is not recognized as an internal or external command,
operable program or batch file.
done.
    Server address: http://:::4000
  Server running... press ctrl-c to stop.

jens-na commented Jan 24, 2014

After running jekyll with jekyll serve -w it says:

...
Server address: http://:::4000
...

This doesn't make sense. It should be http://[::]:4000/ or http://[::1]:4000/ for IPv6. Seems like it's not just a oneliner :-)

@XhmikosR,
127.0.0.1:4000 is an IPv4 address. Please check if it works for http://[::]:4000/ and http://[::1]:4000/.

donatj commented Jan 28, 2014

I'm not a ruby developer so I'm not sure where to go with this but when I try to run Jekyll not via gem via the bin/jekyll I get the following

jdonat > JesseDonat-MBP ~/Projects/jekyll ±master » ./bin/jekyll                                                                                                     17:07:36
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:45:in `require': cannot load such file -- safe_yaml (LoadError)
    from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:45:in `require'
    from /Users/jdonat/Projects/jekyll/lib/jekyll.rb:21:in `<top (required)>'
    from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:45:in `require'
    from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:45:in `require'
    from ./bin/jekyll:6:in `<main>'

If anyone can help me out getting started I'm interested in seeking out the aforementioned bugs.

Owner

parkr commented Jan 29, 2014

@donatj You need to run sudo gem install safe_yaml and run sudo gem install for every gem in the bundle. I'd suggest using bundler, and running bundle exec ./bin/jekyll.

Owner

parkr commented Feb 25, 2014

I think we want to punt on this.

@mattr- mattr- added this to the 2.1 milestone Feb 25, 2014

Owner

mattr- commented Feb 25, 2014

agreed. I've moved it to 2.1 for now.

@parkr parkr closed this Mar 17, 2014

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.