New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoffeeScript conversion support #1991

Merged
merged 1 commit into from Jan 31, 2014

Conversation

Projects
None yet
7 participants
@parkr
Member

parkr commented Jan 26, 2014

Along with Sass (#1932) support, our vision for Jekyll 2.0 includes support for CoffeeScript out-of-the-box.

I've written a Jekyll plugin called jekyll-coffeescript which handles all the logic and contains the converter. This PR just integrates this plugin into Jekyll core.

});
}).call(this);
JS

This comment has been minimized.

@afeld

afeld Jan 30, 2014

Contributor

Why not move this into an external file as well?

This comment has been minimized.

@parkr

parkr Jan 30, 2014

Member

The only place I can think to put this is test/source/js/result.js or something, and it didn't seem to make a lot of sense:

I didn't want the check to be eff'd up if Jekyll freaks out, i.e. I wanted to isolate my check from all the other tests in the test suite and from all erroneous Jekyll-related behaviours.

This comment has been minimized.

@afeld

afeld Jan 30, 2014

Contributor

Fair enough!

This comment has been minimized.

@parkr

parkr Jan 30, 2014

Member

😃 Thanks for asking though. I often do crazy things that make sense in my head, but don't make sense to anyone else.

@benbalter

This comment has been minimized.

Contributor

benbalter commented Jan 30, 2014

Can't wait for this to drop. This and #1932 are going to seriously level up Jekyll.

@parkr

This comment has been minimized.

Member

parkr commented Jan 30, 2014

@benbalter Just needs @mattr-'s 👀 :)

mattr- added a commit that referenced this pull request Jan 31, 2014

@mattr- mattr- merged commit 2b97346 into master Jan 31, 2014

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Jan 31, 2014

@mattr- mattr- deleted the coffeescript branch Jan 31, 2014

@mattr-

This comment has been minimized.

Member

mattr- commented Jan 31, 2014

Dropped the 💣 on y'all. 💥

@parkr

This comment has been minimized.

Member

parkr commented Jan 31, 2014

It's all good – thanks @mattr-!!

@vinitkumar

This comment has been minimized.

vinitkumar commented Jan 31, 2014

But will it be supported on Github pages? AFAIK github doesn't allow plugins.

@parkr

This comment has been minimized.

Member

parkr commented Jan 31, 2014

@vinitkumar It supports built-in plugins, like this one!

@vinitkumar

This comment has been minimized.

vinitkumar commented Jan 31, 2014

Yeah. I confused it with the other custom plugins. That's a really great addition. Thanks! 👍

@gmile

This comment has been minimized.

Contributor

gmile commented Jan 31, 2014

@parkr not sure if it's the right place to ask this, but is native haml support on the radar (even if it's a distant future)?

@mattr-

This comment has been minimized.

Member

mattr- commented Jan 31, 2014

HAML will never be available due to allowing arbitrary code execution.

On Fri, Jan 31, 2014 at 3:14 AM, Pirogov Evgenij notifications@github.com
wrote:

@parkr not sure if it's the right place to ask this, but is haml on the radar (even if it's a distant future)?

Reply to this email directly or view it on GitHub:
#1991 (comment)

@gmile

This comment has been minimized.

Contributor

gmile commented Jan 31, 2014

@mattr- gotcha. Thanks for clarifying this!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.