New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong semantic #2013

Merged
merged 1 commit into from Feb 4, 2014

Conversation

Projects
None yet
4 participants
@doktorbro
Member

doktorbro commented Feb 4, 2014

No description provided.

@parkr

This comment has been minimized.

Member

parkr commented Feb 4, 2014

Hey, can you please explain why this is necessary?

@troyswanson

This comment has been minimized.

Member

troyswanson commented Feb 4, 2014

<p> tags are not allowed to have child block level elements (such as other <p> tags), so this markup is technically failing HTML validation presently.

Here's what it looks like right now in the wild, which is invalid.

<p class="post-content">
    <p>...</p>
    <p><em>Maintainer’s note: Many thanks to @gregose and @charliesome for discovering these vulnerabilities, and to @BenBalter and @alindeman for writing the patch. -@parkr</em></p>
</p>

Switching that parent <p> to a <div> is the appropriate way to go, for sure.

parkr added a commit that referenced this pull request Feb 4, 2014

@parkr parkr merged commit 5849da3 into jekyll:master Feb 4, 2014

1 check passed

default The Travis CI build passed
Details
@parkr

This comment has been minimized.

Member

parkr commented Feb 4, 2014

Thanks for the explanation @troyswanson! 🤘

parkr added a commit that referenced this pull request Feb 4, 2014

@troyswanson

This comment has been minimized.

Member

troyswanson commented Feb 4, 2014

Of course. 🙇

@doktorbro doktorbro deleted the doktorbro:patch-1 branch Feb 5, 2014

@doktorbro

This comment has been minimized.

Member

doktorbro commented Feb 5, 2014

Hey, can you please explain why this is necessary?

Sorry for the missing description. I was in a hurry and thought it was obvious.

@parkr

This comment has been minimized.

Member

parkr commented Feb 5, 2014

I was in a hurry and thought it was obvious.

@penibelst No problem! If it's not obvious to me, I'll ask (as above). Not expecting an immediate response of course (async, and all that). Thanks for the PR!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.