Setup rouge at Runtime rather than "Interpret-Time" #2079

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@parkr
Member
parkr commented Feb 19, 2014

Rouge was being require'd even if it wasn't being used. This should change that.

Fixes #2055 and #2057.

@mattr- mattr- was assigned by parkr Feb 20, 2014
@parkr parkr added this to the 2.0 milestone Feb 20, 2014
@parkr parkr added the Fix label Feb 20, 2014
@parkr
Member
parkr commented Feb 20, 2014

Currently hopelessly broken. No idea how to fix it.

@mattr-
Member
mattr- commented Feb 20, 2014

No worries. I'll take a look at it.

@mattr-
Member
mattr- commented Feb 25, 2014

What's broken about this? Seems to be working fine. I don't hit the code path that pulls in the rouge requires unless i've got

highlighter: rouge
markdown: redcarpet

in my _config.yaml

@mattr-
Member
mattr- commented Feb 25, 2014

never mind. Just saw the error.

parkr and others added some commits Feb 19, 2014
@mattr- mattr- assigned parkr and mattr- and unassigned mattr- and parkr Feb 28, 2014
@parkr
Member
parkr commented Mar 16, 2014

Failure is unrelated to this extension error! You fixed it!

Now to figure out why that one error happened...

@parkr parkr closed this Mar 17, 2014
@parkr parkr reopened this Mar 17, 2014
@benhanzl benhanzl referenced this pull request Apr 1, 2014
Merged

Move rouge loading #2189

@parkr
Member
parkr commented Apr 3, 2014

Superseded by #2189

@parkr parkr closed this Apr 3, 2014
@parkr parkr deleted the dont-need-rouge branch Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment