Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit YAML blocks to end with three dots #2110

Closed
wants to merge 48 commits into
base: master
from

Conversation

Projects
None yet
@lmullen
Copy link
Contributor

lmullen commented Mar 3, 2014

The YAML spec permits blocks to end with three dots (...) in addition to
three dashes (---): http://www.yaml.org/spec/1.2/spec.html#id2760395. Some
programs that work with Jekyll (e.g., Pandoc) prefer the dots to dashes. This
commit permits the YAML metadata block to end with either dots or dashes. It
includes tests.

Permit YAML blocks to end with three dots
The YAML spec permits blocks to end with three dots (...) in addition to
three dashes (---): http://www.yaml.org/spec/1.2/spec.html#id2760395. Some
programs that work with Jekyll (e.g., Pandoc) prefer the dots to dashes. This
commit permits the YAML metadata block to end with either dots or dashes. It
includes tests.
@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 6, 2014

I've given this some thought and I see no reason we should change because of Pandoc's preference. If I've learned anything in the last year, it's that giving users too many ways to do something causes confusion.

Also, the YAML spec gives me rage so I don't care much what they have to say considering omitting the last segment is also valid. 😄

What's the use-case for this?

@lmullen

This comment has been minimized.

Copy link
Contributor Author

lmullen commented Mar 6, 2014

At least one of the reasons for using a plain-text blogging engine is to filter the posts through Unix-lie tools. It seems to me that if the spec says that multiple end of document delimiters are permitted, and if other tools in the same space are using those delimiters, then Jekyll ought to support the full spec (even if you don't like the spec). Pandoc documents now use a YAML header for metadata, just like Jekyll posts. The use case is for files that can be both Pandoc documents and Jekyll blog posts.

Yes, omitting the last segment is valid in a file that contains only YAML, but it wouldn't be valid in a file (like a Jekyll blog post or Pandoc document) that contains other information, so that part of the spec is beside the point.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 10, 2014

What do you think, @mattr-?

@parkr parkr added the Feature label Mar 16, 2014

@parkr parkr closed this Mar 17, 2014

@parkr parkr reopened this Mar 17, 2014

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 24, 2014

@lmullen I don't see any need to keep this from going through. If you wouldn't mind rebasing, I'll merge.

parkr and others added some commits Mar 16, 2014

Added Jekyll-Ordinal plugin to list of third-party plugins.
Closes #2150.

Signed-off-by: Parker Moore <parkrmoore@gmail.com>
add support for unpublished drafts
I keep all my ideas for blog posts as drafts in my draft folder. However I'm
only really working on a couple at once. This let's me mark drafts that I'm
not working on right now as unpublished so they don't clutter the site while
I'm checking on the other drafts.
@lmullen

This comment has been minimized.

Copy link
Contributor Author

lmullen commented Mar 24, 2014

I think I did the rebase correctly; if not, my apologies.

@parkr parkr closed this in 31443e9 Apr 2, 2014

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Apr 2, 2014

Merged in 52ac2b3! Thanks :)

parkr added a commit that referenced this pull request Nov 22, 2014

Revert "Permit YAML blocks to end with three dots"
This reverts commit 52ac2b3, introduced in
v2.0.0 by @lmullen. It has been reverted because it adds complication to
the process of writing Jekyll sites ("Do I use dots or dashes here??") and
because the sole purpose was to bend to the will of pandoc, which could
just as easily prefer dashes to dots.

Ref: #2110, 3134

@parkr parkr referenced this pull request Nov 22, 2014

Closed

Revert "Permit YAML blocks to end with three dots" #3138

1 of 2 tasks complete

parkr added a commit that referenced this pull request Jan 10, 2015

Revert "Permit YAML blocks to end with three dots"
This reverts commit 52ac2b3, introduced in
v2.0.0 by @lmullen. It has been reverted because it adds complication to
the process of writing Jekyll sites ("Do I use dots or dashes here??") and
because the sole purpose was to bend to the will of pandoc, which could
just as easily prefer dashes to dots.

Ref: #2110, 3134

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.