New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modernizr and use html5shiv.js directly. #2131

Merged
merged 2 commits into from Mar 30, 2014

Conversation

Projects
None yet
3 participants
@XhmikosR
Contributor

XhmikosR commented Mar 12, 2014

Also add respond.js so that the site looks good in older IE too.

If this is merged, #2129 becomes obsolete :)

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Mar 12, 2014

Before:
1-before

After:
2-after

@parkr

This comment has been minimized.

Member

parkr commented Mar 12, 2014

Would love to loop in @cobyism for his thoughts on this. I see a significant difference between the two screenshots so I'm not prepared to accept without some sort of approval from Coby :)

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Mar 12, 2014

Well, the reason you see the difference is due to respond.js. Without it, IE < 9 doesn't support media queries thus the difference.

@parkr

This comment has been minimized.

Member

parkr commented Mar 16, 2014

Decided to go with #2129 instead. Supporting older IE doesn't really make sense at the moment. Thank you though!

@parkr parkr closed this Mar 16, 2014

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Mar 16, 2014

I think you missed the point @parkr: you already support old IE since modernizr includes html5shiv.

The idea here is to not force all normal, modern browsers download a file that is basically only used for older IE.

@parkr

This comment has been minimized.

Member

parkr commented Mar 16, 2014

I guess I did miss the point (reading back through the comments, it's only clear once you mentioned it just now).

So here's a question then: to what degree does this change limit the use of other browsers' older versions, e.g. older versions of Firefox or Safari? Will they get shafted?

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Mar 16, 2014

Well, currently I doubt those work anyway (see the CSS PR; so many vendor prefixed properties were missing). Generally, I don't think old versions of Firefox or Safari are affected unless you care about really old versions which my previous point still applies.

See http://caniuse.com/#feat=html5semantic

@XhmikosR XhmikosR referenced this pull request Mar 17, 2014

Merged

CSS tweaks #2127

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Mar 26, 2014

@parkr: I still believe this should be reconsidered. I see no downside from this, but even if you insist on keeping modernizr, which is only used for the html5shiv part, I can only add respond.js for old IE better support.

This branch is rebased so if you re-open the PR it should be ready to merge.

@parkr parkr reopened this Mar 26, 2014

parkr added a commit that referenced this pull request Mar 30, 2014

@parkr parkr merged commit 10669e8 into jekyll:master Mar 30, 2014

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Mar 30, 2014

@XhmikosR XhmikosR deleted the XhmikosR:html5shiv branch Mar 30, 2014

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Mar 31, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.