New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for unpublished drafts #2164

Merged
merged 1 commit into from Mar 23, 2014

Conversation

Projects
None yet
4 participants
@mrtazz
Contributor

mrtazz commented Mar 22, 2014

I keep all my ideas for blog posts as drafts in my draft folder. However I'm
only really working on a couple at once. This let's me mark drafts that I'm
not working on right now as unpublished so they don't clutter the site while
I'm checking on the other drafts.

I only added feature tests since I didn't quite grok if there was something
to add to the unit tests. Please let me know if I should add tests in there
as well.

add support for unpublished drafts
I keep all my ideas for blog posts as drafts in my draft folder. However I'm
only really working on a couple at once. This let's me mark drafts that I'm
not working on right now as unpublished so they don't clutter the site while
I'm checking on the other drafts.
@mattr-

This comment has been minimized.

Member

mattr- commented Mar 23, 2014

Looks fine to me. A draft is a post, so I don't see why we'd need to unit test that logic twice. @parkr?

@mattr- mattr- added the Enhancement label Mar 23, 2014

@mattr- mattr- added this to the 2.0 milestone Mar 23, 2014

parkr added a commit that referenced this pull request Mar 23, 2014

@parkr parkr merged commit 939ff23 into jekyll:master Mar 23, 2014

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Mar 23, 2014

lmullen added a commit to lmullen/jekyll that referenced this pull request Mar 24, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.