New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to force watch to use polling #2165

Merged
merged 1 commit into from Mar 30, 2014

Conversation

Projects
None yet
4 participants
@Zequez
Contributor

Zequez commented Mar 23, 2014

This is useful for people working on shared folders inside virtual machine, Guard believes it's on Linux and listens to inotify, but it doesn't actually work.

@parkr

This comment has been minimized.

Member

parkr commented Mar 27, 2014

Force polling does what, exactly? Should we always force polling? Are you running jekyll on your VM or on your local machine?

@mscharley

This comment has been minimized.

Contributor

mscharley commented Mar 27, 2014

Polling mode is an OS independent mode for Listen that essentially boils
down to manually checking every file for modifications every however long.
Generally it's a pretty large performance hit. I wouldn't recommend forcing
polling on by default, though I do support having a flag for it for edge
cases like this.

listener = Listen.to(
source,
:ignore => ignored,
:force_polling => options['force_polling']

This comment has been minimized.

@parkr

parkr Mar 30, 2014

Member

This will be nil if it's not set. What should it default to?

@mscharley

This comment has been minimized.

Contributor

mscharley commented Mar 30, 2014

Nil sounds sensible to me, that's the same as being unset in the hash.

parkr added a commit that referenced this pull request Mar 30, 2014

@parkr parkr merged commit e277855 into jekyll:master Mar 30, 2014

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Mar 30, 2014

@parkr parkr added this to the 2.0 milestone Mar 30, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.