Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: clean up fonts used. #2185

Merged
merged 1 commit into from Apr 2, 2014

Conversation

Projects
None yet
4 participants
@XhmikosR
Copy link
Contributor

XhmikosR commented Mar 31, 2014

  • remove the unused ones
  • switch to using 700 for bold consistently

The 700 change is in #2127 too, but made more sense to include it here. I will remove it from there after this is merged and I rebase the branch.

@parkr: let me know when you merge this in gh-pages; I'd like to see the performance impact.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 31, 2014

Can the browser not intuit 800? It must be 700 or 900?

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Mar 31, 2014

I tried it and I didn't see any difference; the browser is already using 900.

@mscharley

This comment has been minimized.

Copy link
Contributor

mscharley commented Mar 31, 2014

font-weight: bold; is an alias for 700 or the next heaviest weight that
is specified as available. So, 700 or 800 or 900, whichever is found first.

I'd recommend consistently using either the numerics or the aliases though
for the sake of avoiding confusion.

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Mar 31, 2014

Well that's what I did.

Clean up fonts used.
* remove the unused ones
* switch to using `700` for `bold` consistently
* use `400` for normal font weight
@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 31, 2014

font-weight: bold; is an alias for 700 or the next heaviest weight that
is specified as available. So, 700 or 800 or 900, whichever is found first.

So if we have 700 and 900 available, bold will be 700, not 900? Consistency is great and that's what @XhmikosR did here. :)

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Mar 31, 2014

I changed the only normal instance to 400 too. We should also try to get #2127 merged too for compatibility's sake :)

parkr added a commit that referenced this pull request Apr 2, 2014

@parkr parkr merged commit 293d675 into jekyll:master Apr 2, 2014

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Apr 2, 2014

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Apr 2, 2014

Just deployed: f966adc

@XhmikosR XhmikosR deleted the XhmikosR:docs-fonts branch Apr 2, 2014

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Apr 2, 2014

http://gtmetrix.com/compare/83Aeak0Z/ovfPIZaK

I'd expect a bigger impact, but well :)

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Apr 2, 2014

Looks like it got worse! :(

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Apr 2, 2014

No, left is the newer one :P

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Apr 2, 2014

Oh, HEHE. I am crazy. 🍔 Thank you!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.