New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When more than one category specified in the news item, make sure... #2191

Merged
merged 2 commits into from Apr 1, 2014

Conversation

Projects
None yet
4 participants
@pilosus
Contributor

pilosus commented Apr 1, 2014

... category names formatted nicely with comma delimiter like this: category1, category2. Instead of categor1category2.

For the case when more than one category specified in the news item, …
…make sure category names formatted nicely with comma delimiter like this: category1, category2. Instead of categor1category2.
@budparr

This comment has been minimized.

Contributor

budparr commented Apr 1, 2014

doesn't "array_to_sentence_string" do this?

@parkr

This comment has been minimized.

Member

parkr commented Apr 1, 2014

@budparr is correct: see if you get the same result by applying the array_to_sentence_string filter instead. Should be less code :)

@pilosus

This comment has been minimized.

Contributor

pilosus commented Apr 1, 2014

You are right, array_to_sentence_string does the thing with less code. Didn't know that before, I'm absolutely new to jekyll. Thank you both!

@parkr

This comment has been minimized.

Member

parkr commented Apr 1, 2014

Ideally we would have a different post-category object for each, right?

JK

parkr added a commit that referenced this pull request Apr 1, 2014

@parkr parkr merged commit 8158c81 into jekyll:master Apr 1, 2014

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Apr 1, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.