New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Switch to using an ico file. #2193

Merged
merged 1 commit into from Apr 2, 2014

Conversation

Projects
None yet
3 participants
@XhmikosR
Contributor

XhmikosR commented Apr 1, 2014

Works in all browsers plus it includes a 32x32 icon alongside with the 16x16 one.

Switch to using an ico file.
Works in all browsers plus it includes a 32x32 icon alongside with the 16x16 one.
@parkr

This comment has been minimized.

Member

parkr commented Apr 1, 2014

Does the PNG not work on some browsers?

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Apr 2, 2014

Pretty old browsers I guess, but at least IE10 doesn't show the current favicon too. ico files work fine since every browser looks for "favicon.ico" in the server root.

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Apr 2, 2014

See this screenshot for example:

2014-04-02_09-32-44

parkr added a commit that referenced this pull request Apr 2, 2014

@parkr parkr merged commit 1304f5a into jekyll:master Apr 2, 2014

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Apr 2, 2014

@XhmikosR XhmikosR deleted the XhmikosR:docs-favicon branch Apr 2, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.