New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a to cross-reference about post_url #2243

Merged
merged 3 commits into from Apr 18, 2014

Conversation

Projects
None yet
5 participants
@RadicalZephyr
Contributor

RadicalZephyr commented Apr 18, 2014

I had a really hard time finding this information on the Jekyll site, and this seemed like a reasonable place to put a pointer to the information.

@troyswanson

This comment has been minimized.

Member

troyswanson commented Apr 18, 2014

Cool idea! 👍

I think this would be better suited as a ProTip™, though. Also, the specific wording could probably be improved. Try to take yourself out of the copy. Definitely don't include any first-person nouns like "I" or "me". I think we're even trying to stay away from second-person nouns like "you", as well.

Something like this might be better:

ProTip™: Link to other posts
Use the post_url tag to link to other posts without worrying changing URLs.

RadicalZephyr added some commits Apr 18, 2014

Add a to cross-reference about post_url
I had a really hard time finding this information on the Jekyll site,
and this seemed like a reasonable place to put a pointer to the
information.
Remove "tag" from the link
It looks super weird
@RadicalZephyr

This comment has been minimized.

Contributor

RadicalZephyr commented Apr 18, 2014

That's a good call. I changed it to a pro-tip.

@troyswanson

This comment has been minimized.

Member

troyswanson commented Apr 18, 2014

Yeaaaaah! 👍

Post a screenshot for easy sharing!

@mscharley

This comment has been minimized.

Contributor

mscharley commented Apr 18, 2014

👍

Quick proofreading:

Use the post_url tag to link to other posts without having to worry about changing the URL when you change permalink styles.

Reword slightly to fix typo
Also avoid using "you" as well

parkr added a commit that referenced this pull request Apr 18, 2014

@parkr parkr merged commit 810c160 into jekyll:master Apr 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@troyswanson

This comment has been minimized.

Member

troyswanson commented Apr 18, 2014

🎉

parkr added a commit that referenced this pull request Apr 18, 2014

@parkr

This comment has been minimized.

Member

parkr commented Apr 18, 2014

Thanks for putting this together guys 😃

@parkr

This comment has been minimized.

Member

parkr commented Apr 18, 2014

@troyswanson

This comment has been minimized.

Member

troyswanson commented Apr 18, 2014

Mmmmm. Tasty.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.