New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sitemap.xml to Template Site #2259

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@0xcaff
Copy link
Contributor

0xcaff commented Apr 29, 2014

Something like this. There is an atom.xml here. This is for a sitemap. I'll create and PR one.

@mscharley

This comment has been minimized.

Copy link
Contributor

mscharley commented Apr 23, 2014

Yea, sorry, I screwed up my first comment and realised almost immediately. Perhaps this should be added as an extension to jekyll/jekyll-help#7 however, there's a lot of the same concerns (url's, etc). I've also got an example implementation via plugin at https://bitbucket.org/matthew-scharley/matt.scharley.me/src/d5531861bf9054537dd2fecacd873227ec1142c9/plugins/sitemap_generator.rb?at=master. There may be something to be taken from that as well.

@0xcaff

This comment has been minimized.

Copy link
Contributor Author

0xcaff commented Apr 23, 2014

I don't think it would require a plugin. See mine: Rendered Source

@0xcaff 0xcaff changed the title Add sitemap.xml to template site Add sitemap.xml to Template Site Apr 23, 2014

@mscharley

This comment has been minimized.

Copy link
Contributor

mscharley commented Apr 23, 2014

Definitely doesn't require one (see my atom implementation in the same
repo, arguably even more complex), though Ruby logic is often a lot cleaner
and easier to read/understand than Liquid logic. Anything in the base setup
should definitely be in liquid though.

On 24 April 2014 04:36, Martin Charles notifications@github.com wrote:

I don't think it would require a plugin. See mine: Renderedhttp://caffinatedmonkey.github.io/sitemap.xml
Sourcehttp://caffinatedmonkey/caffinatedmonkey.github.io/blob/source/sitemap.xml


Reply to this email directly or view it on GitHubhttps://github.com//issues/2259#issuecomment-41198089
.

@0xcaff

This comment has been minimized.

Copy link
Contributor Author

0xcaff commented Apr 23, 2014

True, though the templates can be run on github pages and are easier to customize.

Edit: Oops! I misread your post!

@parkr parkr referenced this pull request Apr 23, 2014

Closed

Open-Source? #5

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Apr 23, 2014

What do you think about using something like the jekyll-sitemap plugin and just adding it to the _config.yml?

@0xcaff

This comment has been minimized.

Copy link
Contributor Author

0xcaff commented Apr 23, 2014

I think we should wait for GitHub Pages support.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Apr 23, 2014

Workin' on it. github/pages-gem#62

@troyswanson

This comment has been minimized.

Copy link
Member

troyswanson commented Apr 29, 2014

@parkr Please correct me if I'm wrong, but this is good to go on GitHub Pages. Set up seems pretty easy, too. Seems like all you have to do is include jekyll-sitemap in the gems list in your _config.yml file.

Example:

gems: [jekyll-sitemap]

Is this right?

@budparr

This comment has been minimized.

Copy link
Contributor

budparr commented Apr 29, 2014

@troyswanson worked for me, though I used

gems:
  - jekyll-sitemap 

. Here's the blog post on it: https://help.github.com/articles/sitemaps-for-github-pages

@0xcaff

This comment has been minimized.

Copy link
Contributor Author

0xcaff commented Apr 29, 2014

Done! I have converted this issue to a Pull Request with the appropriate commits!

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Apr 29, 2014

Merpppppp, do we want to bundle this? /cc @benbalter

@benbalter

This comment has been minimized.

Copy link
Contributor

benbalter commented Apr 29, 2014

Issue would be you'd need the Gem in the resulting site. So we'd have to go the Gemfile route, which I believe you previously 👎'd?

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Apr 29, 2014

Yeah I didn't like it. I don't think we need to add unnecessary weight to the template site. Let's make it lightweight – it's already soooo easy to add a sitemap with this gem. I don't see it being wanted in 100% of the instances someone would want to use the template site

selfie-3

Thanks for the idea tho!

@parkr parkr closed this Apr 29, 2014

@0xcaff 0xcaff deleted the 0xcaff:sitemap branch Apr 30, 2014

@0xcaff

This comment has been minimized.

Copy link
Contributor Author

0xcaff commented Apr 30, 2014

:shrug:

@troyswanson

This comment has been minimized.

Copy link
Member

troyswanson commented Apr 30, 2014

Mo' options, mo' problems. Good work everyone!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.