New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two new test cases for exclude configuration use cases. #2303

Merged
merged 2 commits into from May 6, 2014

Conversation

Projects
None yet
5 participants
@parkr
Member

parkr commented May 6, 2014

Extension of #2046, not excluding an item from the list of files if it starts with one of the excluded items.

Closes #2046.

/cc @jbranchaud

@parkr

This comment has been minimized.

Member

parkr commented May 6, 2014

@benbalter You ran into frustrations with the exclude key recently – what do you think of these changes?

@parkr parkr added this to the 2.0 milestone May 6, 2014

@mattr-

This comment has been minimized.

Member

mattr- commented May 6, 2014

Also LGTM. :shipit:

@parkr parkr merged commit 6c1bb76 into master May 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the jbranchaud-adding_exclude_tests branch May 6, 2014

parkr added a commit that referenced this pull request May 6, 2014

@benbalter

This comment has been minimized.

Contributor

benbalter commented May 6, 2014

My frustration was around excluding /vendor without excluding /assets/vendor. Not sure if this fixes that?

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.