Adding two new test cases for exclude configuration use cases. #2303

Merged
merged 2 commits into from May 6, 2014

Conversation

Projects
None yet
5 participants
@parkr
Member

parkr commented May 6, 2014

Extension of #2046, not excluding an item from the list of files if it starts with one of the excluded items.

Closes #2046.

/cc @jbranchaud

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 6, 2014

Member

@benbalter You ran into frustrations with the exclude key recently – what do you think of these changes?

Member

parkr commented May 6, 2014

@benbalter You ran into frustrations with the exclude key recently – what do you think of these changes?

@parkr parkr added this to the 2.0 milestone May 6, 2014

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- May 6, 2014

Member

Also LGTM. :shipit:

Member

mattr- commented May 6, 2014

Also LGTM. :shipit:

@parkr parkr merged commit 6c1bb76 into master May 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the jbranchaud-adding_exclude_tests branch May 6, 2014

parkr added a commit that referenced this pull request May 6, 2014

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter May 6, 2014

Contributor

My frustration was around excluding /vendor without excluding /assets/vendor. Not sure if this fixes that?

Contributor

benbalter commented May 6, 2014

My frustration was around excluding /vendor without excluding /assets/vendor. Not sure if this fixes that?

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.