Test docs with Proofer #2311

Closed
wants to merge 37 commits into
from

Projects

None yet

3 participants

Member

Second attemp for #2088. I hope

NOKOGIRI_USE_SYSTEM_LIBRARIES=true

does the trick.

@parkr parkr and 1 other commented on an outdated diff May 7, 2014
site/_posts/2014-05-05-jekyll-2-0-0-released.markdown
@@ -28,4 +28,4 @@ Happy developing!
[changelog]: /docs/history/
[@jglovier]: https://github.com/jglovier
-[jekyll-1]: {% post_url 2013-05-05-jekyll-1-0-0-released %}
+[jekyll-1]: {% post_url 2013-05-06-jekyll-1-0-0-released %}
parkr
parkr May 7, 2014 Owner

This works with the previous URL: http://jekyllrb.com/news/2014/05/06/jekyll-turns-2-0-0/

ATM it's timezone-specific because safe_yaml pre-1.0 was weird about timezones.

penibelst
penibelst May 7, 2014 Member

I thought the argument must be post’s file name.

Owner
parkr commented May 7, 2014

Merge conflict 😿 Would you mind a quick rebase?

Owner
parkr commented May 7, 2014

Our total build time is averaging 13-17 minutes. This PR brings that up to 31 minutes. Can we do this another way? I don't want to have to wait 30 minutes to know whether I can merge a PR...

Member

I don't want to have to wait 30 minutes to know whether I can merge a PR...

30 minutes is too much. What about moving the proofer test to the gh-pages branch only? Does Travis allow this?

Member

Another option is to use one gemfile for regular tests, and one gemfile for docs test with latest released Jekyll only. Travis says:

For Ruby projects, env, rvm, gemfile, and jdk can be given as arrays to construct a build matrix.

Owner
parkr commented May 7, 2014

Can we run the docs check in the latest ruby version, but still check jekyll's unit/integration tests in 1.9.3, 2.0.0, and 2.1?

Member

Can we run the docs check in the latest ruby version, but still check jekyll's unit/integration tests in 1.9.3, 2.0.0, and 2.1?

I think so. I’ll update the pull request.

Member

Can we run the docs check in the latest ruby version, but still check jekyll's unit/integration tests in 1.9.3, 2.0.0, and 2.1?

The matrix is ready. I have an issue to build the docs: https://travis-ci.org/jekyll/jekyll/jobs/24838766 Can @jekyll/owners please investigate?

Owner
parkr commented May 10, 2014

add exclude: [vendor] to the _config.yml and try again!

Member

@parkr Exclude does the trick.

Member

Look at the results. The site test

  1. is shorter than the integration test;
  2. is allowed to fail;
  3. runs on the latest stable Ruby and Jekyll.
Member

With NOKOGIRI_USE_SYSTEM_LIBRARIES=true the docs test takes only 2:43.

Member

I think it’s done. The Rebund logic can be improved according to the env variable, but I don’t know how Rebund works.

@parkr parkr commented on an outdated diff May 10, 2014
@@ -7,7 +7,7 @@ rvm:
- 2.1.1
- 2.0.0
- 1.9.3
-script: script/cibuild
+script: if [[ "$SITE" == true ]]; then script/proofer; else script/cibuild; fi
parkr
parkr May 10, 2014 Owner

Hm, could we do this in script/cibuild instead? Feels weird to have it here

Owner
parkr commented May 10, 2014

Let's also add a timezone to the _config.yml. Maybe try America/New_York? Should streamline it for everyone :)

Member

Everything is done.

@parkr parkr and 1 other commented on an outdated diff May 10, 2014
script/cibuild
script/branding
-bundle exec rake
+if [ "$SITE" ]; then
+ cd ./site
+ bundle exec jekyll build --trace
+ bundle exec htmlproof ./_site
+else
+ bundle exec rake
+fi
+
+
parkr
parkr May 10, 2014 Owner

Can you remove this extra space, please? :)

@parkr parkr and 1 other commented on an outdated diff May 10, 2014
site/_config.yml
permalink: /news/:year/:month/:day/:title/
excerpt_separator: noifniof3nioaniof3nioafafinoafnoif
+exclude: [vendor]
+timezone: Europe/London
parkr
parkr May 10, 2014 Owner

Why did you choose this timezone?

penibelst
penibelst May 10, 2014 Member

It is about a London lawyer named Gabriel John Utterson who investigates strange occurrences between his old friend, Dr. Henry Jekyll, and the evil Edward Hyde.

Member

@parkr Do you still have any performance concerns? If tests run in parallel, the site test is the shortest one, so you don’t wait more than usual.

Member

Low priority.

@penibelst penibelst closed this May 14, 2014
@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.