When Jekyll is in safe mode, it never outputs "included file *** not found" error #2344

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Owner

parkr commented May 7, 2014

parkr added some commits May 7, 2014

First check if the path exists, then check if it's a symlink.
Previously, if safe mode was on, somehow this always was returned, even if the the file wasn't a symlink.
Owner

parkr commented May 7, 2014

@benbalter Look OK to you?

Contributor

benbalter commented May 8, 2014

This may disclose file existence via symlink. I'd make the logic: are we in safe mode and symlink'd? Error. Does the file not exist? Error. That better reflects intended behavior.

Owner

parkr commented May 9, 2014

The actual problem is that the prefixed_with? method doesn't include _includes in its checker so it always returns true.

@parkr parkr closed this May 21, 2014

@parkr parkr deleted the include-not-found branch Dec 29, 2014

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.