New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use where filter with collections #2359

Merged
merged 2 commits into from May 9, 2014

Conversation

Projects
None yet
4 participants
@abroder
Contributor

abroder commented May 8, 2014

Similar to #2328, the where filter doesn't work with collections because #[] doesn't exist for StaticFile. This fixes it using item_property based off of @penibelst's fix in #2345.

@doktorbro

This comment has been minimized.

Member

doktorbro commented May 8, 2014

Nice catch, bro.

@parkr parkr merged commit e278997 into jekyll:master May 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@parkr

This comment has been minimized.

Member

parkr commented May 9, 2014

Does this need to be done for the group_by filter as well?

parkr added a commit that referenced this pull request May 9, 2014

@abroder

This comment has been minimized.

Contributor

abroder commented May 9, 2014

group_by is using item_property already, so it works with collections

@parkr

This comment has been minimized.

Member

parkr commented May 9, 2014

Cool, thanks! 👍

@abroder abroder deleted the abroder:where-collection branch May 9, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.