New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve anchor_links.html #2368

Merged
merged 2 commits into from May 12, 2014

Conversation

Projects
None yet
3 participants
@XhmikosR
Contributor

XhmikosR commented May 9, 2014

I will rebase this as soon as #2367 is merged.

  • fix TypeError when we are in home
  • remove default type and encoding
  • reformat the code
  • move JS before </body>
@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented May 10, 2014

@parkr: I can rebase the branch to skip the wrong post change if you want to merge this before the other PR.

@parkr

This comment has been minimized.

Member

parkr commented May 10, 2014

So many curly brackets we don't need! My Ruby eyes are bleeeeeeedddiiiinngggggggggg

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented May 10, 2014

Well, for starters JS isn't Ruby... And I'd rather have the brackets than breaking stuff without noticing (Hint: Apple's OpenSSL bug).

EDIT: I removed the post patch to keep the PR clean.

XhmikosR added some commits May 9, 2014

Update anchor_links.html.
* fix `TypeError` when we are in home
* remove default type and encoding
* format the code

parkr added a commit that referenced this pull request May 12, 2014

@parkr parkr merged commit 31d7afc into jekyll:master May 12, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 12, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.