New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use Ruby 2.1.2 #2374

Merged
merged 1 commit into from May 9, 2014

Conversation

Projects
None yet
4 participants
@albertogg
Member

albertogg commented May 9, 2014

Do you think we should update this right away? travis is ready and given that 2.1.1 had a regression I think we should.

@parkr

This comment has been minimized.

Member

parkr commented May 9, 2014

Yes! If the build is green, I'll merge. 💥

@parkr parkr self-assigned this May 9, 2014

@albertogg

This comment has been minimized.

Member

albertogg commented May 9, 2014

AHAHAHA, omg... I skipped the ci what a dumb ass

@albertogg

This comment has been minimized.

Member

albertogg commented May 9, 2014

👏

parkr added a commit that referenced this pull request May 9, 2014

@parkr parkr merged commit aee7d73 into jekyll:master May 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 9, 2014

@doktorbro

This comment has been minimized.

Member

doktorbro commented May 9, 2014

@parkr I’m curious, why is always the patch version (2.1.2, 1.9.3) set instead of the minor (2.1, 1.9)?

@parkr

This comment has been minimized.

Member

parkr commented May 9, 2014

@parkr I’m curious, why is always the patch version (2.1.2, 1.9.3) set instead of the minor (2.1, 1.9)?

Tradition? I have no good reason for >= 2.0. For 1.9.3, the .3 is important, whereas the -p453 isn't.

@doktorbro

This comment has been minimized.

Member

doktorbro commented May 9, 2014

Tradition sounds funny. If you set the minor version only, Travis chooses the latest Ruby patch version. I believe.

@albertogg albertogg deleted the albertogg:update-ruby branch May 9, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.