New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `Jekyll.env` and `jekyll.environment` #2417

Merged
merged 3 commits into from May 17, 2014

Conversation

Projects
None yet
6 participants
@parkr
Member

parkr commented May 17, 2014

  • Create Jekyll.env (by @envygeeks)
  • Load Jekyll.env into jekyll.environment for Liquid use
  • Test it

Fixes #2413. Replaces #2414.

parkr added a commit that referenced this pull request May 17, 2014

@parkr parkr merged commit 4147e92 into master May 17, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the jekyll-env branch May 17, 2014

parkr added a commit that referenced this pull request May 17, 2014

@penibelst

This comment has been minimized.

Show comment
Hide comment
@penibelst

penibelst May 18, 2014

Member

Thank you @envygeeks and @parkr.

Member

penibelst commented May 18, 2014

Thank you @envygeeks and @parkr.

@danott

This comment has been minimized.

Show comment
Hide comment
@danott

danott Aug 1, 2014

@parkr Do you know if there is any way to configure the jekyll.environment that Github Pages will use? From a test, I see it reports as 'development' (but I'd like it to be 'production').

danott commented Aug 1, 2014

@parkr Do you know if there is any way to configure the jekyll.environment that Github Pages will use? From a test, I see it reports as 'development' (but I'd like it to be 'production').

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 1, 2014

Contributor

You should email support@github and ask them to kick on the production flag via JEKYLL_ENV so that you get access to it.

Contributor

envygeeks commented Aug 1, 2014

You should email support@github and ask them to kick on the production flag via JEKYLL_ENV so that you get access to it.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Aug 1, 2014

Member

Since it isn’t boolean, would it be better for GH-Pages to set it to something like “github-pages”?

Member

pathawks commented Aug 1, 2014

Since it isn’t boolean, would it be better for GH-Pages to set it to something like “github-pages”?

@penibelst

This comment has been minimized.

Show comment
Hide comment
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Dec 1, 2014

Contributor

This makes me wonder if we can pull that data somehow without creating a circular depend that leads to some nasty stuff, if Github uses site.github[:environment] == "dotcom" we should find a way to detect that (but tbh it might be rather hard because of the aforementioned.)

Contributor

envygeeks commented Dec 1, 2014

This makes me wonder if we can pull that data somehow without creating a circular depend that leads to some nasty stuff, if Github uses site.github[:environment] == "dotcom" we should find a way to detect that (but tbh it might be rather hard because of the aforementioned.)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 1, 2014

Member

I submitted a support request to GitHub to set JEKYLL_ENV=production. It should be trivial for them, and it'd make more sense for us to be GHP-agnostic as much as possible.

Member

parkr commented Dec 1, 2014

I submitted a support request to GitHub to set JEKYLL_ENV=production. It should be trivial for them, and it'd make more sense for us to be GHP-agnostic as much as possible.

@penibelst penibelst referenced this pull request Dec 9, 2014

Closed

Ignore some environments #25

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.