Spice up site_template feed #2438

Merged
merged 1 commit into from May 30, 2014

Conversation

Projects
None yet
4 participants
@pathawks
Member

pathawks commented May 23, 2014

Added some features to the template feed that are used by jekyllrb.com

@@ -15,6 +18,12 @@ layout: none
<pubDate>{{ post.date | date: "%a, %d %b %Y %H:%M:%S %z" }}</pubDate>
<link>{{ post.url | prepend: site.baseurl | prepend: site.url }}</link>
<guid isPermaLink="true">{{ post.url | prepend: site.baseurl | prepend: site.url }}</guid>
+ {% for tag in post.tags %}
+ <category>{{ tag | xml_escape }}</category>

This comment has been minimized.

@parkr

parkr May 23, 2014

Member

If tags aren't categories, why include them here?

@parkr

parkr May 23, 2014

Member

If tags aren't categories, why include them here?

This comment has been minimized.

@pathawks

pathawks May 24, 2014

Member

Honestly, the reason it is included here is because that's how it is in the jekyllrb.com feed template. If it makes more sense to leave this out that'd be an easy fix, but is there a reason it is included there and not here?

@pathawks

pathawks May 24, 2014

Member

Honestly, the reason it is included here is because that's how it is in the jekyllrb.com feed template. If it makes more sense to leave this out that'd be an easy fix, but is there a reason it is included there and not here?

This comment has been minimized.

@parkr

parkr May 30, 2014

Member

@benbalter, have any thoughts here? I'm inclined to accept even if the semantics are kind of off.

@parkr

parkr May 30, 2014

Member

@benbalter, have any thoughts here? I'm inclined to accept even if the semantics are kind of off.

This comment has been minimized.

@pathawks

pathawks May 30, 2014

Member

I'm inclined to accept even if the semantics are kind of off.

If that's the only hold up, I can just leave out tags.
The only reason I did this is because that's the way jekyllrb.com is handling tags.

@pathawks

pathawks May 30, 2014

Member

I'm inclined to accept even if the semantics are kind of off.

If that's the only hold up, I can just leave out tags.
The only reason I did this is because that's the way jekyllrb.com is handling tags.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 23, 2014

Member

I'm totally up for this. @benbalter, any thoughts?

Member

parkr commented May 23, 2014

I'm totally up for this. @benbalter, any thoughts?

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter May 30, 2014

Contributor

👍

Contributor

benbalter commented May 30, 2014

👍

parkr added a commit that referenced this pull request May 30, 2014

@parkr parkr merged commit 041f727 into jekyll:master May 30, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 30, 2014

@pathawks pathawks deleted the pathawks:spicy-feed branch May 31, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.