New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of different Twitter and Github usernames in default theme #2485

Merged
merged 3 commits into from Jun 9, 2014

Conversation

Projects
None yet
3 participants
@tomer
Contributor

tomer commented Jun 7, 2014

Currently it is impossible to use different names on Github and Twitter without changing the default template files. I suggest using different keywords in order to make it easier to customize the output without digging into the theme files.

As a added-value, I also added conditional to show these links only if the keywords are set on _config.yml, so people who would like to show only their twitter identity should just remove the github-username keyword from the config file. ☺

tomer added some commits Jun 7, 2014

Allow usage of different Twitter and Github usernames
and show these links only if twitter-username or github.username are set on _config.yml
Show outdated Hide outdated lib/site_template/_config.yml
@@ -4,6 +4,8 @@ email: your-email@domain.com
description: "Write an awesome description for your new site here. You can edit this line in _config.yml. It will appear in your document head meta (for Google search results) and in your feed.xml site description."
baseurl: ""
url: "http://yourdomain.com"
twitter-username: jekyllrb
github-username: jekyll

This comment has been minimized.

@parkr

parkr Jun 8, 2014

Member

Let's use underscores here instead of hyphens: twitter_username and github_username, respectively.

@parkr

parkr Jun 8, 2014

Member

Let's use underscores here instead of hyphens: twitter_username and github_username, respectively.

This comment has been minimized.

@tomer

tomer Jun 9, 2014

Contributor

Done on commit 411cdb2.

@tomer

tomer Jun 9, 2014

Contributor

Done on commit 411cdb2.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 8, 2014

Member

One comment, but LGTM otherwise!

Member

parkr commented Jun 8, 2014

One comment, but LGTM otherwise!

parkr added a commit that referenced this pull request Jun 9, 2014

@parkr parkr merged commit dd3e980 into jekyll:master Jun 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jun 9, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.