New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hl_lines highlighting #2532

Merged
merged 4 commits into from Jun 25, 2014

Conversation

Projects
None yet
6 participants
@alexmedearis
Contributor

alexmedearis commented Jun 19, 2014

This allows for key/value pairs of the form key="value1 value2 value3" to be passed as arguments to highlight.

In particular, hl_lines="3 4 5" etc. is valid highlight syntax, but previously did not parse correctly.

@parkr

@alexmedearis

This comment has been minimized.

Contributor

alexmedearis commented Jun 19, 2014

In reference to #516

@parkr

This comment has been minimized.

Member

parkr commented Jun 23, 2014

This LGTM. Can you please add an example in the docs, too? Thanks!

/cc @mattr- for his 👀

@parkr

This comment has been minimized.

Member

parkr commented Jun 25, 2014

@mattr-'s verdict:

👍 :shipit:

@parkr

This comment has been minimized.

Member

parkr commented Jun 25, 2014

Hrm, feeling weird about this. Can I have some other 👀 / :brain:s on this? @benbalter / @envygeeks?

@envygeeks

This comment has been minimized.

Contributor

envygeeks commented Jun 25, 2014

👍

parkr added a commit that referenced this pull request Jun 25, 2014

@parkr parkr merged commit cedbdf4 into jekyll:master Jun 25, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jun 25, 2014

@nasht00

This comment has been minimized.

Contributor

nasht00 commented Nov 5, 2015

I know this is old, but is there a way to make this work with the backtick syntax?

@nasht00

This comment has been minimized.

Contributor

nasht00 commented Nov 22, 2015

Does this work on Jekyll 3.0 with rouge?

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.